Devuan bug report logs - #176
vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID

Package: vde2; Maintainer for vde2 is (unknown); Source for vde2 is src:vde2.

Reported by: Guenther Brunthaler <5i6itdpybzgshcivvdxsjck8@nurfuerspam.de>

Date: Sat, 20 Jan 2018 07:03:01 UTC

Severity: normal

Tags: debian, jessie

Forwarded to https://bugs.debian.org/1031003

Subject: bug#176: vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID
Reply-To: Guenther Brunthaler <5i6itdpybzgshcivvdxsjck8@nurfuerspam.de>, 176@bugs.devuan.org
Resent-From: Guenther Brunthaler <5i6itdpybzgshcivvdxsjck8@nurfuerspam.de>
Resent-To: devuan-bugs@lists.dyne.org
Resent-CC: owner@bugs.devuan.org
Resent-Date: Sat, 20 Jan 2018 07:03:01 UTC
Resent-Message-ID: <handler.176.B.15164310073721@bugs.devuan.org>
Resent-Sender: owner@bugs.devuan.org
From: Guenther Brunthaler <5i6itdpybzgshcivvdxsjck8@nurfuerspam.de>
To: Devuan Bug Tracking System <submit@bugs.devuan.org>
Message-ID: <5c3fe9c4-ad74-2704-b73e-a5ce50ba3163@nurfuerspam.de>
Date: Sat, 20 Jan 2018 07:43:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Package: vde2
Version: 2.3.2+r586-1
Severity: normal
X-Debbugs-Cc: 5i6itdpybzgshcivvdxsjck8@nurfuerspam.de

Dear Maintainer,


Preliminary remark: Even though I am using Devuan rather then Debian, I
have verified that the problem still exists in the current "stretch"
version (vde2_2.3.2+r586-2.1_amd64.deb) of the package.

"ifup" for a virtual VDE2 tun/tap plug records an incorrect PID for the
vde_plug2tap process in the pidfile, and "ifdown" will therefore not be
able to shut it down.

As a consequence, the vde_plug2tap process keeps running, wasting
resources, and the tun/tap interface remains still visible with
ifconfig -a, even though it will have been deconfigured.

The problem arises when using ifup/ifdown to configure additional
tun/tap interfaces for a VDE2 switch.

Such additional network interfaces are necessary when binding normal
applications running on the local box (and not in VM guests) to
different VLANs managed by the same virtual VDE2 switch.

For instance, when adding the following /etc/network/interfaces entry

iface ethsmb inet static
        vde2-plug vde_plug2tap -p 5 -s /var/run/vde2/ethvm.ctl ethsmb
        address 10.35.43.113
        netmask 255.255.0.0

then "ifup ethsmb" makes a new network interface "ethsmb" appear which 
is connected to port 5 on the virtual switch (which itself manages 
another network interface "ethvm").

"ifdown ethsmb" should make the new interface go away, but it won't.

The problem is located in plug-in script /etc/network/if-pre-up.d/vde2
from the package.

This script contains a command

start-stop-daemon --start --quiet --pidfile $PIDFILE \
--make-pidfile --background \
--exec $DPIPE -- $VDE_PLUG -g $GROUP -m 660 $CTLDIR = "$@"

It seems dpipe double-forks under certain situations, at least in this
case, and so the --background option of start-stop-daemon has no effect
and the --pidfile captures the wrong PID.

This can also be verified by just running the resulting dpipe command
manually without the "start-stop-daemon": It returns immediately,
obviously forking the processes into the background, and $! does *not*
contain a valid process ID.

I have also figured out what needs to be changed in order to make 
everything work as intended again: Just exchange the order of commands 
connected with dpipe. In other words, change the

   --exec $DPIPE -- $VDE_PLUG -g $GROUP -m 660 $CTLDIR = "$@"

line into

   --exec $DPIPE -- "$@" = $VDE_PLUG -g $GROUP -m 660 $CTLDIR

It turns out that the order of commands in dpipe is not irrelevant if 
the processes have different lifetimes.

In such a case, the first command must be that with the longer lifetime, 
because dpipe will exec itself into that command, and its PID will be 
used by the caller of dpipe in order to terminate the pipeline later.

-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 1.0 (jessie)
Release:	1.0
Codename:	jessie
Architecture: x86_64

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_AT.UTF-8, LC_CTYPE=de_AT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages vde2 depends on:
ii  adduser      3.113+nmu3
ii  libc6        2.19-18+deb8u10
ii  libpcap0.8   1.6.2-2
ii  libvde0      2.3.2+r586-1
ii  libvdeplug2  2.3.2+r586-1

vde2 recommends no packages.

Versions of packages vde2 suggests:
pn  qemu           <none>
ii  qemu-kvm       1:2.1+dfsg-12+deb8u6
ii  vde2-cryptcab  2.3.2+r586-1

-- no debconf information

Send a report that this bug log contains spam.

Devuan bug report logs - #176 vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID

Devuan bug report logs - #176
vde2: ifup plugin-stanza "vde2-plug" does not capture correct PID