Devuan bug report logs - #227
nbd-client: At shutdown nbd-client disabled before file-systems could be cleanly unmounted

Package: sysvinit-utils; Maintainer for sysvinit-utils is Devuan Developers <devuan-dev@lists.dyne.org>; Source for sysvinit-utils is src:sysvinit.

Affects: nbd-client

Reported by: David Kuehling <dvdkhlng@posteo.de>

Date: Mon, 16 Jul 2018 00:03:01 UTC

Severity: normal

Tags: upstream

Fixed in version 3.07-1

Done: Mark Hindley <mark@hindley.org.uk>

Full log

Message #29 received at 227@bugs.devuan.org (full text, mbox, reply):

Received: (at 227) by bugs.devuan.org; 16 Feb 2023 16:28:37 +0000
Return-Path: <jessefrgsmith@yahoo.ca>
Delivered-To: bugs@devuan.org
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Thu, 16 Feb 2023 16:28:37 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id C4e2OWJZ7mN0UQAAmSBk0A
	(envelope-from <jessefrgsmith@yahoo.ca>)
	for <bugs@devuan.org>; Thu, 16 Feb 2023 16:27:14 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id C679DA0; Thu, 16 Feb 2023 16:27:14 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_PASS
	autolearn=ham autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=74.6.131.124; helo=sonic311-14.consmr.mail.bf2.yahoo.com; envelope-from=jessefrgsmith@yahoo.ca; receiver=<UNKNOWN> 
Received: from sonic311-14.consmr.mail.bf2.yahoo.com (sonic311-14.consmr.mail.bf2.yahoo.com [74.6.131.124])
	by email.devuan.org (Postfix) with ESMTPS id D552223
	for <227@bugs.devuan.org>; Thu, 16 Feb 2023 16:27:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.ca; s=s2048; t=1676564826; bh=Gw+hKeqXuum0lnAKVZd5Us+sz2EQwg8xbx24cVAhfsI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject:Reply-To; b=UiM56mhDf+VqIfWOCHpewc3CkPBA+zb3XhhZYh2Ir2OzpWJM0pmo+mkW/zCC//Wwsy5SvcaABuRs5PNYfTksmMO/Rei4ZURWTZmdRL9MQzVspXKXSLZCiNfWGi7WcZn2vjV7/4WmRYjycK3MyqSkYelzJFMZGiDtlsIT1GVz08ix6nLpRMtMsLizNWP2tiy07oHvtsCVpc583SIwHIEIc0ebNFqbwy4WI67e9SV8knjHlgdCe37VaJRUFqeyku8ZdtZ6ImgEr4LPNLYiFdk3lfRbbReU6FYrFuliegISyBP0U3wGOvsKducAoXHPVdWH6f0BvnZzlW65walHgn5xbA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676564826; bh=gSCcX1caN6P0agSpQBxWpIyRBivQssSO8o2FWdEutgc=; h=X-Sonic-MF:Subject:To:From:Date:From:Subject; b=nqBiX8Xhnspo6eUVrmQ28oxrsmBH6djng0dRlqBjqMDkq3XOY37J6vnUgNmPrx4OvTUBhw5r4/y5GbPpJ8dhSy2tXWNvsR9g3fsqBIfhLtxRQNmW3a63xLQEEhsV7KPeCQH2aAVuJFRJjXscLh9tgZfMiCXUXgAA9nDdGrLCdJvagjZAn/lfvxPyAuaDxFjSfHsvhAryuiPaUTaHu+MLNQRCdLKUVSM7wFucIWM9VYEc6n9KJ05C65MFmbY8szagBBN3IL51lmJ3J2CTAEAK2CxIahJQkmwdGW9zVz8x4BSi9qwzi6gzlMHaucL9vPQ39IE41Qqcszc8td4Wy5LVNw==
X-YMail-OSG: LCNL0XsVM1kKTWtQ4jHjVKrk8tU_F3isot6Pp11lsaWFVdqRFJjlB9COeAN50l4
 kdHJ.ETkSynyvCydU.7YtjFXX2BEBcgF.A3Xmg9U47Fzyd7w8dPJt0iDwFpgoJYc1UonE7TSop4z
 0MbhFcYM_wo5bDpYGXBCgfBuTbuRP3FyNDO81gBJMHs5Cjrh51SEbxtw6WAEYAeDX0gDd.uTAO0k
 DwdvyNKyg8pfyjM8I0Kyngpb2MscPsYGvXQ.GCTyqm54I4QsdYPQ2lgF8VhjtukYxCfMKsTkLR.E
 BoKGGnpUoAd..gvM62AnmN6dVRM5TaSfvuKcNcjaTI.D8Lb45bLJ9t.b7qBThhPaFGkfrbbfiXt6
 lu4K7rT2CN.Fyg6hi7YJ14JRCHCf7ICql6Os01ZYoca7XXB.XKtNFvRHl5hkR3gX1eR3bxtMddje
 y1VfbcFBYD8GI1Zp4VFE89_06K1rthWR_NPyIICrmYd2mDR2mBaYr9vSFQwupyQPYc9HIjlvFVm9
 l2k5RCiYQB3Swi4ke6BHPk615U243VFLepFT1c_HXamWy2hNI6u2D2gu_02h3LbRrp1W5N1Keq3G
 U7sTdxmMvXVq0qDbyKMu6zo1XJhwG8ko_scNlz7g3MamobBKAvs15qGNOx7GRZWV7QLNeTa_5qPZ
 WXuplqP5Ec7vEwOlEm9mjONiPBJlDbL.F2Km7pcFHZaFzJx4zmxGHqWkZWc.wrqrXuVPUovceySW
 M4_vl4j.NRV9ftErR4eGKGObKp6mNcv1ah0Fbk14FMCFtfMuK6Ka.LVzTCIhgQIPncI3bSiye6rN
 4.PSIleh66xLmfU87bE46psPpOzZgdOKTBDjZCysSFpgXNXp5fpgxSzkCc0FL8ZWzf.4t_d1sp7p
 QtxEAmG6LMBoZVQeCraeded9NA2RNbDn4Z3mjs1YBk7cj4DztH1TLD_j5wAUEfIlzIgb39G7XltS
 8gFIRAeOJespGTlYC.mHd9x1QWn5BnTTwZMI23Vgg0FMSDpagNlM10UaZJNZAE.TSftxM2qmIs7o
 .6U5TbY6IUhk0ZTyzUNyoSZHWmdKKfow76r8FM.Y09IBBMc8omQSXiF_dTvHInDtAYeScutQ712s
 Zmz5ViW8MrJx7pzfNHiYvye5czqNjb2CWH7C3nf2mWzLR5blQzAW6yTb4_mDakMPFjiBRrczKunp
 Agt5RIjLqMdrpCkX7hSZinkgQ6CJ_3ep_VcC8MP9H1zZG_TjQGNbynN0fDnvX0lQm7oh6WNqKq7R
 9GuMxnwRe6L96lflHZQaN9i7eB3ad5qIjs7yOMlg0AMvnrbReivfxaqtCNWAiMDIIDChWYa5H2Fd
 wvgF3W4l9Kr_K6W8XbrUNAKFt51cuYqS7ih01XCAaU7Q3rX0Y.w9qItIEzlZEget41jAqf1Q8_ZY
 WioGsu5aDvMAlsNmdtgOLWneaT6JLZ4cbfu4WV80lOLgXsSJr3qwBWciQHMQFYMzG_1afMzory19
 Ih8R2MpVpHU6kYaTLoV8pvUTIlsl_HT7apiv4_MsWzveLCWsAHSQvUG6kXQ0nECTcdN_XYSpgohO
 Kt8P5hOb5ViSyPgdh7EGqqXg5.8GlrcWrxWtzXq.HF8BM_ShaChkyUgDg4sBJqg1en1cyFP.9Fhi
 tzJwJwxGG7UJsIzwsF8g0pdlbsg428oIzJmr6VvLSKIgCYkAKOC8u09dm9d92U0.gqnDP.7ff7G9
 FEFhDuV75Asa8St31n4A9Ael_ZFXS_xA9M.v_k_VmJpzKsSBBPeNflp5F1ywW5FBVchcP7i5tpyH
 U2Qw_UcvJ3GHxJrGft0pWb2rVg5Xxv36zghRZxok1QlXfUkl4vileWLNw2PfFW4WKciXfKkB6u0_
 E1.JlRWznbwG.xOAlM5RDu.8J5RiGM1KLBgPzFKlV9Nx.76b24ikwTyRKoQ9BOGYkULX6KnyccVE
 Q_oKDRlXjvaBgxvhxS0xVnBEPAsxAd4CPsTskW7auowifHYngtpmthKVY6ZiPISwSUIgzbqjblr9
 yq6ey9D2QtIMO2JnDRW9dFjBqVD3F5Bf2y1zNREfSf4kcFi3Q58Ed5SFjqL51M09HUWelWHiWgl3
 Eye6WNlY7PGuKHyIUXm3onIVrqtCX5uqYmH3jHFUgY4rSDXtQMcV83.xeLAjnJJ2lATUelAcVjig
 1kGIO6jviQu3BNisad7Y0Pcvequ029rQwYrXleIV_rpy8cJRXVqAPzH.6Jmbn_sNiSGY26TrG8E6
 UdUocM6BxLP_JzDuGP9Y6wURW2aiZty2Yz0.HEZN2wj2Nl2rF_bs1kf1Qcg--
X-Sonic-MF: <jessefrgsmith@yahoo.ca>
Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Thu, 16 Feb 2023 16:27:06 +0000
Received: by hermes--production-gq1-655ddccc9-hdxk5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7d7ad19d4afba9ac7c2286525f4a4431;
          Thu, 16 Feb 2023 16:27:01 +0000 (UTC)
Subject: Re: bug#227: nbd-client: At shutdown nbd-client disabled before
 file-systems could be cleanly unmounted
To: Mark Hindley <mark@hindley.org.uk>
Cc: David Kuehling <dvdkhlng@posteo.de>, 227@bugs.devuan.org
References: <87r2k4njjg.fsf@snail.snail.pool>
 <Y+5KRGlB5crallrj@hindley.org.uk>
 <e4623351-4e7c-3623-926d-1d08a0965278@resonatingmedia.com>
 <Y+5XMAODvbjKHf/k@hindley.org.uk>
From: Jesse Smith <jessefrgsmith@yahoo.ca>
Message-ID: <3ddc31b5-a513-7a75-5538-60af01f3c881@yahoo.ca>
Date: Thu, 16 Feb 2023 12:26:59 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <Y+5XMAODvbjKHf/k@hindley.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-CA
X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo

On 2023-02-16 12:17 p.m., Mark Hindley wrote:
> Control: reassign -1 sysvinit-utils
> Control: affects -1 nbd-client
>
> Jesse,
>
> Thanks for you quick reply.
>
> On Thu, Feb 16, 2023 at 11:54:32AM -0400, Jesse Smith wrote:
>> I see two possible ways we could fix this:
>>
>> 1. Create a command line flag which disables the SIGSTOP and SIGCONT
>> signals being sent. This is an easy fix, quick and dirty. The potential
>> downside is if someone disables the STOP signal then maybe processes
>> terminate, move groups, or are replaced before we get around to sending
>> them the KILL signal. This probably won't happen, but it means killall5
>> is working with a "moving target".
>>
>> 2. We can run SIGSTOP on all processes _except_ those in the omit list.
>> This will be a lot slower than the existing "kill(-1, SIGSTOP)" call we
>> currently make. But I think it's more correct.
>>
>> Basically the new work flow would look like this:
>>
>> 1. Send all processes except those omitted the SIGSTOP command.
>> 2. Send all processes except those omitted the SIGKILL command.
>> 3. Send all processes except those omitted the SIGCONT command.
>>
>> Option #2 is slow and ugly, but seems "correct" from a behaviour point
>> of view.
> I don't really like #1: it will mean patching callers to get the (more?) correct
> behaviour. So #2 seems better. Will it be significantly slower?. You could only
> use it when omitpid is specified? If there are no omitpids, the current
> behaviour seems fine.
>
>
if I had to guess, I'd assume the new approach would be about 3x slower.
But we're probably talking about loops that will finish in a thousandths
of a second. From a practical point of view, I don't think anyone will
see the difference. And, as you pointed out, if there is no list of
omitted PIDs then we can revert to the old way of doing things.

I'll look at fixing this and testing it this weekend. See if I can fix
this without breaking anything else.

- Jesse

Send a report that this bug log contains spam.

Devuan bug report logs - #227 nbd-client: At shutdown nbd-client disabled before file-systems could be cleanly unmounted

Devuan bug report logs - #227
nbd-client: At shutdown nbd-client disabled before file-systems could be cleanly unmounted