Devuan bug report logs - #262
[atop] ..atop installs systemd cron job on non-systemd Devuan box...

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.devuan.org (full text, mbox, reply):

Package: atop
Version: 2.2.6-4
Severity: normal


Hi,

..my first attempt wound up in the partially wrong place, upstream:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913364 because of
https://bugs.devuan.org//cgi/bugreport.cgi?bug=256

Package: atop
Version: 2.2.6-4
Severity: normal

--- Please enter the report below this line. ---

..on installing atop, I found things going at a glacial pace, a 
wee part of global climate change, and this fine new cron job:
root@box:~# cat /etc/cron.d/atop
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root if [ -d "/run/systemd/system" ]; then systemctl restart
atop; else /usr/share/atop/atop.daily \& ; fi

..commenting it out, "brought back life."

..we need to keep an eye out for such systemd tricks causing such DOS,
one way is chk which init system is installed, and then install the
correct cron job file.
root@box:~# dpkg -l atop |grep atop |fmt -tu
ii atop 2.2.6-4 amd64 Monitor for system resources and process activity


--- System information. ---
Architecture: 
Kernel:       Linux 4.18.0-0.bpo.1-rt-amd64

Debian Release: 9
  500 stable-updates  deb.devuan.org 
  500 stable-security deb.devuan.org 
  500 stable          deb.devuan.org 
  100 stable-proposed-updates deb.devuan.org 
  100 stable-backports deb.devuan.org 
  100 experimental    deb.devuan.org 

--- Package information. ---
Depends                    (Version) | Installed
====================================-+-=============
libc6                      (>= 2.14) | 2.24-11+deb9u3
libncurses5                   (>= 6) | 6.0+20161126-1+deb9u2
libtinfo5                     (>= 6) | 6.0+20161126-1+deb9u2
zlib1g                  (>= 1:1.1.4) | 1:1.2.8.dfsg-5
init-system-helpers       (>= 1.18~) | 1.48+devuan2.0
lsb-base                 (>= 3.2-14) | 4.1+devuan2


Recommends       (Version) | Installed
==========================-+-===========
cron                       | 3.0pl1-128+deb9u1
 OR cron-daemon            | 


Package's Suggests field is empty.

-- 
..med vennlig hilsen = with Kind Regards from Arnt Karlsen
...with a number of polar bear hunters in his ancestry...
  Scenarios always come in sets of three: 
  best case, worst case, and just in case.

Message #10 received at 262@bugs.devuan.org (full text, mbox, reply):

On Thu, 22 Nov 2018 02:15:59 +0100, Arnt wrote in message 
<20181122021559.60f6ac16@d44>:
> 
> ..which part of:" # daily restart of atop at midnight
> 0 0 * * * root if [ -d "/run/systemd/system" ]; then systemctl \
> restart atop; else /usr/share/atop/atop.daily \& ; fi" "on a
> non-systemd box" did you miss?

[...]

> ..this bug is insisting on assuming systemctl etc systemd commands 
> and totally disregarding the fact some of us throw out junk "init"
> binaries and move on with ye aulde relics that just works, and fix 
> atop in https://bugs.devuan.org//cgi/bugreport.cgi?bug=262 when we 
> get such clear wont-fix hints in Message #15. 
> 
> ..if you Debian etc systemd guys _do_ wanna fix your #913364, put 
> back in the test for systemd and install atop.cronsystemd if you 
> find systemd on your boxes, and give the rest of us back our 
> beloved atop.cronsysv.  Etc.  Easily found in your well documented 
> $favorite_mirror/debian/pool/main/a/atop/atop_*tar* balls.


..instead you test for systemd every damned time cron runs atop...:
cat /etc/cron.d/atop:"
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root if [ -d "/run/systemd/system" ]; then systemctl
restart atop; else /usr/share/atop/atop.daily \& ; fi "

...when that test should happen once, everytime atop is upgraded to 
a new version, or reinstalled, or downgraded to a known good working
version etc, to _decide_which_version_ /etc/cron.d/atop to install,
either /etc/cron.d/atop.sysv _OR_ /etc/cron.d/atop.systemd.


..my _fixed_ /etc/cron.d/atop for non-systemd Devuan etc boxes...:"
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root /usr/share/atop/atop.daily \& "

...works nicely enough to warrant closing this bug.



..I would _guess_  an /etc/cron.d/atop like ...: "
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root systemctl restart atop \& "

...would work for systemd boxes.


-- 
..med vennlig hilsen = with Kind Regards from Arnt Karlsen
...with a number of polar bear hunters in his ancestry...
  Scenarios always come in sets of three: 
  best case, worst case, and just in case.

Message #19 received at 262-done@bugs.devuan.org (full text, mbox, reply):

Version: 2.4.0-1

Send a report that this bug log contains spam.