Devuan bug report logs - #319
openrc savecache doesnt run start()

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.devuan.org (full text, mbox, reply):

[Message part 1 (text/plain, inline)]

Package: openrc

Version: 0.40.3-1

Severity: normal



Dear Maintainer,


The start() routine in /etc/init.d/savecache does not run. If you run my

attached savecache (rc-service savecache start), "SAVECACHE TEST GOT HERE"
will

be displayed, but "SAVECACHE TEST NOT GETTING HERE" will not be displayed.
The start() routine is never entered.


The problem stems from the LSB header information in savecache. These lines
of

code are somehow confusing openrc-run, openrc-run never runs start().


If the LSB header info is removed, savecache runs fine; start() is then run.




Next issue, is savecache even needed? It appears this script is to run in

runlevel off at shutdown, to save /run/openrc/deptree and
/run/openrc/softlevel

to /lib/rc. Arent deptree and softlevel always re-generated at startup
anyway?

Are these cached files in /lib/rc ever used?




Next, if the cached files are used and needed, wouldnt /var/cache be a
better

home for them, something like /var/cache/openrc?




-- System Information:

Distributor ID: Devuan

Description: Devuan GNU/Linux beowulf/ceres

Release: 10

Codename: n/a

Architecture: x86_64


Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)

Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)

Shell: /bin/sh linked to /bin/dash

Init: sysvinit (via /sbin/init)

LSM: AppArmor: enabled

Versions of packages openrc depends on:

ii init-system-helpers 1.56+devuan1

ii insserv 1.18.0-2

ii libaudit1 1:2.8.4-2

ii libc6 2.28-8

ii libeinfo1 0.40.3-1

ii libpam0g 1.3.1-5

ii librc1 0.40.3-1

ii libselinux1 2.8-1+b1

openrc recommends no packages.


Versions of packages openrc suggests:

pn policycoreutils <none>

ii sysvinit-core 2.93-8+devuan1

[Message part 2 (text/html, inline)]

[savecache (application/octet-stream, attachment)]

Message #10 received at 319@bugs.devuan.org (full text, mbox, reply):

I believe the problem to be in openrc-run.sh, the code at/around line 245:

# Load our script
lsbh=$(lsb2rcconf "$RC_SERVICE")
if [ -n "${lsbh}" ]; then
eval "${lsbh}"
else
sourcex "$RC_SERVICE"
.
.
.


I ran rc-service with the -d debug option:
rc-service -dv savecache start
Both with the LSB header present and not present, in /etc/init.d/savecache.

When running WITH the LSB header present, variable lsbh becomes:
+ lsb2rcconf /etc/init.d/savecache
+ lsbh=depend () {
        provide _all
}
And subsequently, the code at line 247 gets run:
if [ -n "${lsbh}" ]; then
eval "${lsbh}"
(This is the problem where savecache start() doesnt get run)

When running WITHOUT the LSB header present, variable lsbh becomes:
+ lsb2rcconf /etc/init.d/savecache
+ lsbh=
And subsequently, the "else" code at line 249 gets run:
else
sourcex "$RC_SERVICE"
.
.
.
(savecache start() runs)

To resolve the problem, the LSB header could simply be removed from
/etc/init.d/savecache.

I wonder why LSB is being examined at all in openrc-run scripts, I
thought (wrongly?) that LSB support was only added for /bin/sh run
scripts, so to use the sysvinit scripts without modification, in
openrc.

Message #15 received at 319-done@bugs.devuan.org (full text, mbox, reply):

Version: 0.45.2-2

This was fixed in Debian with the removal of the bogus LSB header from
savecache.

Closing.

Mark

Send a report that this bug log contains spam.