Devuan bug report logs - #392
When pid1==runit, mis-detects container and doesn't start

version graph

Package: eudev; Maintainer for eudev is Devuan Dev Team <devuan-dev@lists.dyne.org>; Source for eudev is src:eudev.

Reported by: KORN Andras <korn-debbugs@elan.rulez.org>

Date: Sun, 9 Feb 2020 10:48:02 UTC

Severity: normal

Found in version 3.2.9-4

Done: Svante Signell <svante.signell@gmail.com>

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.devuan.org
Subject: bug#392: [devuan-dev] bug#392: When pid1==runit, mis-detects container and doesn't start
Reply-To: svante.signell@gmail.com, 392@bugs.devuan.org
Resent-From: Svante Signell <svante.signell@gmail.com>
Resent-To: devuan-bugs@lists.dyne.org
Resent-CC: Devuan Dev Team <devuan-dev@lists.dyne.org>
X-Loop: owner@bugs.devuan.org
Resent-Date: Mon, 10 Feb 2020 09:18:01 +0000
Resent-Message-ID: <handler.392.B392.158132626918926@bugs.devuan.org>
Resent-Sender: owner@bugs.devuan.org
X-Devuan-PR-Message: followup 392
X-Devuan-PR-Package: eudev
X-Devuan-PR-Keywords: 
References: <20200209103448.lancgj764wum4y4x@hellgate> <20200209103448.lancgj764wum4y4x@hellgate>
Received: via spool by 392-submit@bugs.devuan.org id=B392.158132626918926
          (code B ref 392); Mon, 10 Feb 2020 09:18:01 +0000
Received: (at 392) by bugs.devuan.org; 10 Feb 2020 09:17:49 +0000
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Mon, 10 Feb 2020 09:17:49 +0000 (UTC)
Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id 7FABEF6094A
	for <392@bugs.devuan.org>; Mon, 10 Feb 2020 10:16:25 +0100 (CET)
Authentication-Results: vm6.ganeti.dyne.org;
	dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QQqui9/Y";
	dkim-atps=neutral
Received: by mail-lf1-f54.google.com with SMTP id 203so3610595lfa.12
        for <392@bugs.devuan.org>; Mon, 10 Feb 2020 01:16:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=message-id:subject:from:reply-to:to:date:in-reply-to:references
         :organization:user-agent:mime-version:content-transfer-encoding;
        bh=vpkUC0C4INK5Mh4MOXOOc73L+LbV6TL6ZINWx1+fTyA=;
        b=QQqui9/YHl8FCnRVkd/5dsfD0rm2/1zCjmEkINiTwt+5d/MBBR6gd9nJtj24xZxdn7
         hz1if2WKV02V/nthYqS1vibuPZYKRB0SumcrcuO1bsT+fqZD5+XidbPBCcNwexOzgUcP
         CRL2UxqwXrTc31jY1Y5LN2RnifGw8EdKOTC/NctzwJvGE/NL3rJa+X7El55kxdrtx67r
         9+A67IkANpRBPBgp1RInprv+IReDZCsZek18PZWT9drSG4GdnfUOP1Vcqaxm0oib+HMb
         0b2w805Qd0S9Eb5agESilleYZfy2zeBWCmqc1hacyM5JWUVRRwee875un4bFXElB6m2Q
         Mlaw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:reply-to:to:date
         :in-reply-to:references:organization:user-agent:mime-version
         :content-transfer-encoding;
        bh=vpkUC0C4INK5Mh4MOXOOc73L+LbV6TL6ZINWx1+fTyA=;
        b=kJiDiyvKGzw5yUyxS/T8uqhrJEW/novCSrfEfgBHNsBdGs2Bwi5UN4Tbl6HdnBol4K
         qYCP2GWTEhjz3tMnfKg1t8b60vkjZCAeDwQFr3Zfv5HS1VbGSn6e4bPhyoS5QuZLBgFU
         CpRr2rTtKN5l9a0vaZyv1wdLSM4hIluYlHmuUs3XMXy3GroBk7prgrTFFZKlyp2T1oUL
         LiXdhiLyudMjDeqJJMPV0LCerqe6Rd1mlf5VbPYz0dt5Yx26mdn4Ar5BDW0TdRQMrUlH
         ERTtwa/Qt6yEEL9EZtVRPbqYwbp/HsNSEN4fmgm+9GjERpwMh205ooE0uQdusmuUmfn0
         /YMQ==
X-Gm-Message-State: APjAAAXFip0UpDqlaGBeNkIfPxPzrfOdb5niSKF1qF7eNB6WpP3gJlZ+
	i+yfgZLUmmtTlxDc08tlYFrBLUWc
X-Google-Smtp-Source: APXvYqwiv2a13sPzJuc35trV0rX5JfiOlOFg+b0UT57kXH5w/3TACu0zEf32lEo/HZ0h1Qnxma61MQ==
X-Received: by 2002:a19:5f5e:: with SMTP id a30mr235790lfj.183.1581326183051;
        Mon, 10 Feb 2020 01:16:23 -0800 (PST)
Received: from G3620.lan (178-78-231-178.customers.ownit.se. [178.78.231.178])
        by smtp.gmail.com with ESMTPSA id l12sm5959146lji.52.2020.02.10.01.16.22
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 10 Feb 2020 01:16:22 -0800 (PST)
Message-ID: <bad90e57db6ae9cfd8828a87f7f6ee608bb22900.camel@gmail.com>
From: Svante Signell <svante.signell@gmail.com>
To: 392@bugs.devuan.org
Date: Mon, 10 Feb 2020 10:17:41 +0100
In-Reply-To: <20200209103448.lancgj764wum4y4x@hellgate>
Organization: Home
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org
On Sun, 2020-02-09 at 11:34 +0100, KORN Andras wrote:
> Package: eudev
> Version: 3.2.9-4
> Severity: important
> 
> Hi,
> 
> the /etc/init.d/eudev initscript has this bit:
> 
> if ! ps -p1|grep -q "init\|systemd"; then
>   log_warning_msg "udevd does not support containers, not started"
>   exit 0
> fi

Thank you for your report.

So the name of pid 1 for runit-init is runit?
Then the test could be
-q "init\|runit\|systemd"

What about other init systems, like openrc-init? Perhaps the test should be
reversed if ps -p1 | -q "container tests here" instead.

The Debian package has a worse bug, the test is
if [ ! -w /sys ]; then which is always true, making it impossible to start udev
manually.

> If running with runit as the init system (which is obviously neither
> sysvinit nor systemd), the script exits without starting eudev, which
> results in no keyboard and mouse under X and no local way of switching to a
> text console.
> 
> Perhaps use virt-what to detect containers instead?

I've been looking for methods to detect containers, but have not found virt-
what. Do you have a link or a description?

Send a report that this bug log contains spam.


Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.

Devuan Bugs Owner <owner@bugs.devuan.org>.
Last modified: Fri Apr 26 07:37:48 2024;