Devuan bug report logs - #499
Smokeping service unable to stop/restart

Full log

🔗 View this message in rfc822 format

MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
X-Loop: owner@bugs.devuan.org
From: "Devuan bug Tracking System" <owner@bugs.devuan.org>
To: Mark Hindley <mark@hindley.org.uk>
Subject: bug#499: marked as done (Smokeping service unable to stop/restart)
Message-ID: <handler.499.D499.167343930226351.ackdone@bugs.devuan.org>
References: <Y76oFfCIEnQ5z+IQ@hindley.org.uk> <20200727174615.GA4706@ascii>
X-Devuan-PR-Message: closed 499
X-Devuan-PR-Package: smokeping
X-Devuan-PR-Keywords: debian
Reply-To: 499@bugs.devuan.org
Date: Wed, 11 Jan 2023 12:16:01 +0000
Content-Type: multipart/mixed; boundary="----------=_1673439361-28452-0"

[Message part 1 (text/plain, inline)]

Your message dated Wed, 11 Jan 2023 12:14:13 +0000
with message-id <Y76oFfCIEnQ5z+IQ@hindley.org.uk>
and subject line Fixed in Debian #989354
has caused the Devuan bug report #499,
regarding Smokeping service unable to stop/restart
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.devuan.org
immediately.)


-- 
499: https://bugs.devuan.org/cgi/bugreport.cgi?bug=499
Devuan Bug Tracking System
Contact owner@bugs.devuan.org with problems

[Message part 2 (message/rfc822, inline)]

From: ShadowM00n <shadowm00n@airmail.cc>

To: submit@bugs.devuan.org

Subject: Smokeping service unable to stop/restart

Date: Mon, 27 Jul 2020 12:46:15 -0500

Package: smokeping
Version: 2.7.3-2

First-time submitter, so please excuse and correct me on any procedural 
errors on my part.

Basically, the current version of smokeping's init service quietly fails 
to stop smokeping, and then subsequently fails to restart it because the 
process is still running.

My understanding is that between ASCII and Beowulf the service was 
altered in an attempt to improve security. In ASCII, it checked only 
that a process with a saved PID existed; in Beowulf it also tries to 
compare the invocation string to the program string in the process list. 

While this seems a reasonable idea for most daemons, smokeping seems to 
be a bit of an exception -- it runs under an interpreter (perl), and as 
such the stored PID refers to the perl process launching it; naturally, 
the process string differs from the invocation, being e.g.
"/usr/bin/perl /usr/sbin/smokeping --config=/etc/smokeping/config" while 
being launched as "/usr/sbin/smokeping --config=/etc/smokeping/config".

Given this complication, my current personal setup, and my suggestion, 
is to instead check the owner of the process against the $DAEMON_USER 
when stopping, as this is configured to be a package-specific user 
called "smokeping":

< start-stop-daemon --oknodo --stop --retry 3 --quiet --pidfile $PIDFILE --exec $DAEMON --signal 15
> start-stop-daemon --oknodo --stop --retry 3 --quiet --pidfile $PIDFILE --user $DAEMON_USER --signal 15

This seems to work well for me, though I would certainly not be opposed 
to any other working method if this is less than ideal for some reason.

[Message part 3 (message/rfc822, inline)]

From: Mark Hindley <mark@hindley.org.uk>

To: 499-done@bugs.devuan.org

Subject: Fixed in Debian #989354

Date: Wed, 11 Jan 2023 12:14:13 +0000

Version: 2.7.3-4

Send a report that this bug log contains spam.