Subject: bug#506: libvirt-daemon-system should not depend on policykit-1

From: "Thierry B." <[email-masked]>
Date: Wed, 12 Aug 2020 17:41:11 +0200

Package: libvirt-daemon-system
Version: 6.5.0-1
Severity: wishlist

This is a follow-up to Debian bugs reports :

- #897936: libvirt-daemon-system should not depend on policykit-1
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897936

and

- #768376: libvirt-daemon-system: Please downgrade policykit-1
dependency to recommends
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768376

As you can see in these Debian reports, Debian will doing nothing, so
this i a feature request to fork this package to downgrade "policykit-1"
from Depends tp Recommends

---

From: Mark Hindley <[email-masked]>
Date: Thu, 13 Aug 2020 10:05:41 +0100

Thierry,

Thanks for this.

> from Depends tp Recommends

Do you have packaging skills? Would you be prepared to maintain the fork?

Mark

---

From: "Thierry B." <[email-masked]>
Date: Thu, 13 Aug 2020 14:31:56 +0200

> Do you have packaging skills? Would you be prepared to maintain the fork?

I'm afraid not when I read
https://www.debian.org/doc/manuals/maint-guide/start.en.html chapters,
and I never did that for any distribution. Also it means doing it for
all architectures.

The only thing I know is how to remove policikit-1 dependency for
myself, as I have blacklisted this package and need to rebuild gedebi,
synaptic, gparted and libvirt-daemon-system on my system.

Here is what I do each time there is a new version for theses packages:

$ cd ~/tmp
$ apt download libvirt-daemon-system
$ dpkg-deb -x ./libvirt-daemon-system_6.5.0-1_amd64.deb
libvirt-daemon-system_6.5.0-1_amd64
$ mkdir ./libvirt-daemon-system_6.5.0-1_amd64/DEBIAN
$ dpkg-deb -e libvirt-daemon-system_6.5.0-1_amd64.deb
libvirt-daemon-system_6.5.0-1_amd64/DEBIAN
$ nano libvirt-daemon-system_6.5.0-1_amd64/DEBIAN/control # to move
policykit-1 to Recommends
$ mv libvirt-daemon-system_6.5.0-1_amd64.deb
libvirt-daemon-system_6.5.0-1_amd64.deb.old
$ dpkg-deb -b libvirt-daemon-system_6.5.0-1_amd64
$ sudo apt install ./libvirt-daemon-system_6.5.0-1_amd64.deb

---

From: Mark Hindley <[email-masked]>
Date: Thu, 13 Aug 2020 14:17:40 +0100

> and I never did that for any distribution. Also it means doing it for

The Devuan maintainers guide is at

 https://git.devuan.org/devuan/documentation/src/branch/master/maintainers
 
I would be happy to guide you through the process. The good news is that you
don't have to do each architecture separately as the production build process
takes care of that.

Devuan is relatively short of person-power to fork new packages, so it may well
be a while before anybody feels able to take anything extra on. And it is better
to have somebody maintaining who actually makes use of the package.

Best wishes

Mark

---

From: Andreas Messer <[email-masked]>
Date: Fri, 14 Aug 2020 13:11:29 +0200

Hi there, 

On Thu, Aug 13, 2020 at 02:17:40PM +0100, Where all about bugs in Devuan packages is reported wrote:
> [...]

I could step into maintaining this fork if required. (I'm also using
libvirt...)

cheers,
Andreas

-- 
gnuPG keyid: 8C2BAF51
fingerprint: 28EE 8438 E688 D992 3661 C753 90B3 BAAA 8C2B AF51

---

From: Mark Hindley <[email-masked]>
Date: Fri, 14 Aug 2020 12:23:16 +0100

Andreas,

> I could step into maintaining this fork if required. (I'm also using

That would be great -- thanks.

Mark

---

From: "Thierry B." <[email-masked]>
Date: Fri, 14 Aug 2020 13:47:55 +0200

> to have somebody maintaining who actually makes use of the package.

I give it a try to see if if it is something I can handle. I followed
the guide in your link on a new Devuan ceres virtual machine and even I
do not understand about nearly 75% of stuff inside the guide I am used
to git.

Now i am stuck at section #5 "Local build" in "Packaging Workﬂow" ->
https://pastebin.com/Yrn3j7Ux

I did all the steps before excepting this :

So far the guide says nothing about build dependencies. After some
researches I did:

$ sudo mk-build-deps -i
$ sudo apt install ./libvirt-build-deps_6.5.0-1+devuan1_amd64.deb

I also get the sources with "apt source" and I noticed one difference.
There is a "debian/gbp.conf" in git repository that I do not see in
debian sources. I changed "pristine-tar" to "false" as indicated in the
guide but as we can see in pastebin this file seems to be ignored:
> (dpkg-source: info: using options from libvirt/debian/source/options: --tar--ignore=debian/gbp.conf)

Also in "debian/control" section I did not found a source stanza
"Origin" in "debian/control"

---

From: Mark Hindley <[email-masked]>
Date: Fri, 14 Aug 2020 14:51:38 +0100

Thierry,

On Fri, Aug 14, 2020 at 01:47:55PM +0200, Thierry B. wrote:
> I give it a try to see if if it is something I can handle.

Great.

> I followed the guide in your link on a new Devuan ceres virtual machine and
> even I do not understand about nearly 75% of stuff inside the guide I am used
> to git.

If you push your tree to your account on https://git.devuan.org, I will have a
look.

> So far the guide says nothing about build dependencies. After some

One of the nice things about gbp is you don't have to worrk about build-deps --
it handles that for you cleanly in the build chroot without messing with the
host system.

> --tar--ignore=debian/gbp.conf)

I think that is OK. That is just for the build of the new source tarball.

> "Origin" in "debian/control"

If it isn't there, you create it. I usually put it next to the Vcs-* fields.

Thanks.

Mark

---

From: "Thierry B." <[email-masked]>
Date: Fri, 14 Aug 2020 17:07:38 +0200

> If you push your tree to your account on https://git.devuan.org, I will have a
I have this issue for the moment :

https://stackoverflow.com/questions/41144654/git-error-rpc-failed-http-413-curl-22-the-requested-url-returned-error-413-re

so i can't push for the moment

---

From: "Thierry B." <[email-masked]>
Date: Fri, 14 Aug 2020 18:15:31 +0200

> If you push your tree to your account on https://git.devuan.org, I will have a

nope. I believed there was an issue with the qemu nic card in session
mode as I know it has limitations but I get the same result on my host
computer.

$ export LC_ALL=C && git push -u origin master
error: unable to read askpass response from '/usr/bin/ssh-askpass'
Password for 'https://[email-masked]':
Enumerating objects: 116436, done.
Counting objects: 100% (116436/116436), done.
Delta compression using up to 12 threads
Compressing objects: 100% (12530/12530), done.
error: RPC failed; HTTP 413 curl 22 The requested URL returned error: 413
fatal: the remote end hung up unexpectedly
Writing objects: 100% (116436/116436), 572.69 MiB | 6.56 MiB/s, done.
Total 116436 (delta 103155), reused 116331 (delta 103104), pack-reused 0
fatal: the remote end hung up unexpectedly
Everything up-to-date

---

From: "Thierry B." <[email-masked]>
Date: Fri, 14 Aug 2020 20:00:58 +0200

> If you push your tree to your account on https://git.devuan.org, I will have a

OK using ssh instead of https solved my upload issue.
https://git.devuan.org/thierrybo/libvirt/src/branch/suites/unstable

Also the build process changed numerous files **outside** of /debian/
directory that I DID NOT COMMIT

I don't know what to do with them.

> it handles that for you cleanly in the build chroot without messing with the

Then I must have done something wrong because gpb complained about that
and all builddep packages have been installed on the system in
/usr/bin/, not /var/cache/pbuilder/base-ceres.cow/usr/bin/  .

> If it isn't there, you create it. I usually put it next to the Vcs-* fields.

OK

THBO

---

From: Mark Hindley <[email-masked]>
Date: Fri, 14 Aug 2020 19:07:09 +0100

> https://git.devuan.org/thierrybo/libvirt/src/branch/suites/unstable

Thanks. Got it. Building now.

Are you able to get on IRC #devuan-dev?

Mark

---

From: Mark Hindley <[email-masked]>
Date: Fri, 14 Aug 2020 22:02:42 +0100

> I don't know what to do with them.

I usually use the gbp --git-export-dir= option to build elsewhere and avoid
changing the working tree.

I have built your branch and you have made a good start. It builds! I was going
to attach the build log, but it is 6.4M!

I have noticed a couple of things that need to be addressed. I will do a proper
review tomorrow.

Thanks for your work so far.

Mark

---

From: "Thierry B." <[email-masked]>
Date: Fri, 14 Aug 2020 23:08:34 +0200

> Are you able to get on IRC #devuan-dev?

Ah, hot it, bi it is too late!

> Thanks for your work so far.
All this for changing 10 characters in control file!

THBO

---

From: Mark Hindley <[email-masked]>
Date: Sat, 15 Aug 2020 11:04:29 +0100

Thierry,

> All this for changing 10 characters in control file!

Well more for being persistent and being prepared to learn the process :)

You may have seen that Andreas Messer also offered to help.  So you may want to
do this jointly? The d/control Maintainer field can only take a single email address, but
other addresses can be added to Uploaders.

I have had a quick look and these issues struck me as needing attention:

d/control:

 - Set yourself as maintainer.
 - Remove uploaders (or replace with Andreas Messer?).
 - Remove the libvirt-daemon-system-systemd package. It will always be broken in Devuan.
 - Update the libvirt-daemon-system-sysv description to remove the systemd as default/preferred reference.

d/changelog:

 - Add '(Closes: #506)' so the bug will be automatically closed when the package
   enters the archive.
 - Maybe add a 'Fork for Devuan' entry to cover other changes?

Other than that, it builds and is reasonably lintian clean. It will be worth
checking with lintian again after you have made these new changes.

Let me know how you get on. #devuan-dev on irc.freenode.net is a good place to
get quick help.

Thanks

Mark (LeePen)

---

From: "Thierry B." <[email-masked]>
Date: Sat, 15 Aug 2020 15:49:54 +0200

Le 15/08/2020 à 12:04, Mark Hindley a écrit :

>  - Remove uploaders (or replace with Andreas Messer?)> 

Not commited yet.
Please explain the difference between Maintainer and Uploader.
I do not want to set myself as the maintainer as i'm not even able to
handle the whole build process on my computer and test the new deb on my
computer. I am still stucked at the build error and the build-dependency

> it handles that for you cleanly in the build chroot without messing with the

I would like to solve this problem.

>  - Update the libvirt-daemon-system-sysv description to remove the systemd as default/preferred reference.

commited.

But is the removing of 'libvirt-daemon-system-systemd' sufficient to
prevent building the package?

>  - Maybe add a 'Fork for Devuan' entry to cover other changes?

Commited

> checking with lintian again after you have made these new changes.

I don't know how to do that. And I guess I have to do a successfully
local build before.

> Let me know how you get on. #devuan-dev on irc.freenode.net is a good place to

Connected

THBO (thierrybo)

---

From: Mark Hindley <[email-masked]>
Date: Sat, 15 Aug 2020 19:08:39 +0100

> Please explain the difference between Maintainer and Uploader.

The Maintainer is a single email address. It is used by the BTS to forward
bugs to. It doesn't indicate sole responsibility, but is the central contact
point.

Uploaders are other people who share responsibility for a package. There can be
any number of these.

> I would like to solve this problem.

We use gbp with pbuilder/cowbuilder. That means that the host system delegates the build
process to the pbuilder/cowbuilder chroot. That means you can test builds for
other architecture and suites other than the host system.

So first you set up the pbuilder/cowbuilder chroot with

 gbp --git-pbuilder --git-dist=ceres create --mirror http://pkgmaster.devuan.org/merged

That should create an unstable chroot in /var/cache/pbuilder/base-ceres.cow/

Then you build packages using that chroot. As part of this gbp will temporarily install the
necessary build-deps.

 gbp --git-pbuilder --git-dist=ceres --git-export-dir=../build

I use --git-export-dir so the working tree doesn't get changed by the build
process.

Does that make sense.

As far as your build failure goes:-

 - Do you have stray/old source tarballs in the parent directory? That might
   cause it. Try deleting them and letting gbp regenerate them.
  
 - Have you correctly tagged the upstream release? I think you need
   upstream/6.5.0 on commit 38c0fa742. That is how gbp generates the orig.tar.gz

 - If that doesn't work, try the build with --git-verbose and see if that
   produces more helpful error messages.

Hope that helps.

Mark

---

From: "Thierry B." <[email-masked]>
Date: Sun, 16 Aug 2020 17:34:13 +0200

>  gbp --git-pbuilder --git-dist=ceres create --mirror http://pkgmaster.devuan.org/merged

OK this is what is in the maintainer's guide, except I have to use "gbp
buildpackage" otherwise it does not work.
>  gbp --git-pbuilder --git-dist=ceres --git-export-dir=../build

OK, I have to use  "gbp buildpackage" as above.

>    cause it. Try deleting them and letting gbp regenerate them.

Yes I had. I deleted them but get qame "error 127".

>    upstream/6.5.0 on commit 38c0fa742. That is how gbp generates the orig.tar.gz

No, this was not in the guide. And As far a I see, there is already one? :
https://i.imgur.com/8BibW5H.png

>    produces more helpful error messages.

here it is:

https://pastebin.com/p5hXzqbr

THBO

---

From: Mark Hindley <[email-masked]>
Date: Sun, 16 Aug 2020 20:39:35 +0100

> https://i.imgur.com/8BibW5H.png

That's good then.

> https://pastebin.com/p5hXzqbr

Hmmm. I still can't reproduce that.

I wonder -- are you running out of space? It is a reasonably hefty build. The source tree
is 169M alone. I would have thought it could need 2G in /var once you add the
build deps.

Mark

---

From: "Thierry B." <[email-masked]>
Date: Mon, 17 Aug 2020 00:17:27 +0200

> is 169M alone. I would have thought it could need 2G in /var once you add the

I guess it is fine? :

LC_ALL=C df -h
Filesystem      Size  Used Avail Use% Mounted on
udev            980M     0  980M   0% /dev
tmpfs           200M  652K  199M   1% /run
/dev/vda1        18G   11G  6.5G  62% /
tmpfs           5.0M  4.0K  5.0M   1% /run/lock
tmpfs           808M     0  808M   0% /dev/shm
cgroup_root      10M     0   10M   0% /sys/fs/cgroup
tmpfs           200M   32K  200M   1% /run/user/1000

THBO

---

From: Mark Hindley <[email-masked]>
Date: Mon, 17 Aug 2020 10:16:14 +0100

>> pkg-source: info: using source format '3.0 (quilt)'
>> dpkg-source: info: building libvirt using existing ./libvirt_6.5.0.orig.tar.gz
>> dpkg-source: info: using patch list from debian/patches/series
>> dpkg-source: warning: libvirt-6.5.0/debian/changelog(l7): badly formatted trailer line
>> LINE:  -- Thierry Bothorel <[email-masked]>   Sun, 16 Aug 2020 17:02:32 +0200
>> dpkg-source: warning: libvirt-6.5.0/debian/changelog(l9): found start of entry where expected more change data or trailer
>> LINE: libvirt (6.5.0-1+devuan1) unstable; urgency=medium
>> dpkg-source: warning: libvirt-6.5.0/debian/changelog(l9): found end of file where expected more change data or trailer
>> gbp:error: 'git-pbuilder' failed: it exited with 127

The fact that you are using --git-ignore-new and there are changelog parsing
errors suggests you have some unchecked in changes.

I would reset the working tree (or stash them if they might be useful), delete
existing ./libvirt_6.5.0.orig.tar.gz and rebuild without --git-ignore-new.

Once you have a clean tree `dpkg-parsechangelog` should not report any errors.

Hope that helps.

Mark

---

From: "Thierry B." <[email-masked]>
Date: Mon, 17 Aug 2020 14:23:45 +0200

> Once you have a clean tree `dpkg-parsechangelog` should not report any errors.

Yes I removed them, did not changed anything.

Otherwise I decided to install the build environment on my real Devuan
testing computer to see if I have the same problem .... with even less
luck. The cowbuilder chroot creation fails and is stucked at "I:
Retrieving InRelease:":

> bp buildpackage --git-pbuilder --git-dist=ceres create --mirror http://pkgmaster.devuan.org/merged --git-verbose
> gbp:debug: ['git', 'rev-parse', '--show-cdup']
> gbp:debug: ['git', 'rev-parse', '--is-bare-repository']
> gbp:debug: ['git', 'rev-parse', '--git-dir']
> gbp:debug: /bin/true [] []
> gbp:debug: ['git', 'status', '--porcelain']
> gbp:debug: ['git', 'symbolic-ref', 'HEAD']
> gbp:debug: ['git', 'show-ref', 'refs/heads/suites/unstable']
> gbp:info: Building with (cowbuilder) for ceres
> gbp:debug: ['git', 'show-ref', '--verify', 'refs/heads/pristine-tar']
> gbp:debug: ['git', 'show-ref', '--verify', 'refs/remotes/origin/pristine-tar']
> gbp:info: Performing the build
> gbp:debug: git-pbuilder ['create', '--mirror', 'http://pkgmaster.devuan.org/merged'] []
> I: Invoking pbuilder
> I: forking: pbuilder create --buildplace /var/cache/pbuilder/base-ceres.cow --mirror http://pkgmaster.devuan.org/merged --distribution ceres --no-targz --extrapackages cowdancer
> W: /root/.pbuilderrc does not exist
> I: Running in no-targz mode
> W: cgroups are not available on the host, not using them.
> I: Distribution is ceres.
> I: Current time: Mon Aug 17 13:38:41 CEST 2020
> I: pbuilder-time-stamp: 1597664321
> I: Building the build environment
> I: running debootstrap
> /usr/sbin/debootstrap
> I: Target architecture can be executed
> I: Retrieving InRelease 

and the '/var/cache/pbuilder/base-ceres.cow/debootstrap/debootstrap.log'
is filled with:

> amd64: ok
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.
> failed: Connection timed out.

... but this is another story...

By the way if you want to see by yourself I am ready for a Anydesk
session ....

---

From: Mark Hindley <[email-masked]>
Date: Mon, 17 Aug 2020 14:03:26 +0100

> luck. The cowbuilder chroot creation fails and is stucked at "I:

That is because there are infra problems today. pkgmaster.devuan.org is down at
the moment.
 
> By the way if you want to see by yourself I am ready for a Anydesk

OK. I'll install a client. Later this afternoon?

Mark

---

From: "Thierry B." <[email-masked]>
Date: Mon, 17 Aug 2020 15:14:43 +0200

> OK. I'll install a client. Later this afternoon?

I am ready now this afternoon... after that afk until Friday.

THBO

---

From: "Devuan bug Tracking System" <[email-masked]>
Date: Thu, 22 Apr 2021 19:03:08 +0000

This is an automatic notification regarding your bug report
which was filed against the libvirt-daemon-system package:

#506: libvirt-daemon-system should not depend on policykit-1

It has been closed by Andreas Messer <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Andreas Messer <[email-masked]> by
replying to this email.

-- 
506: https://bugs.devuan.org/cgi/bugreport.cgi?bug=506
Devuan Bug Tracking System
Contact [email-masked] with problems

Subject: libvirt-daemon-system should not depend on policykit-1
From: Andreas Messer <[email-masked]>
To: [email-masked]
Date: Thu, 22 Apr 2021 20:55:23 +0200

Version: 6.5.0-1+devuan3

Found this during house-keeping. Was already addressed by 
Thierry B. a while ago.

Andreas

Subject: libvirt-daemon-system should not depend on policykit-1
From: "Thierry B." <[email-masked]>
To: [email-masked]
Date: Wed, 12 Aug 2020 17:41:11 +0200

and