Subject: bug#543: DAEMON_ARGS in /etc/init.d/salt-minion prevents salt-minion startup

From: Samuli Airaksinen <[email-masked]>
Date: Wed, 3 Feb 2021 18:27:14 +0200

Package: salt-minion
Version: 2018.3.4+dfsg1-6+deb10u2

In /etc/init.d/salt-minion , the line

DAEMON_ARGS="-d"

causes the minion to freeze upon startup. The -d switch, which runs the 
minion in the background, is ok when /usr/bin/salt-minion is ran 
interactively, but causes the minion to freeze when launched via service.

The switch is also warned against at 
https://ansible-cn.readthedocs.io/en/latest/topics/troubleshooting/minion.html 
. In Debian Buster the salt-minion service is also launched without the 
-d argument.

There is no error message. The last log message in log_levels "trace" 
and "garbage" is: "Getting lsb_release distro information", after which 
the minion remains unresponsive.

Emptying the DAEMON_ARGS fixes the problem and enables salt-minion to 
start properly.

Proposed patch:

@@ -15,7 +15,7 @@
  DESC="salt minion control daemon"
  NAME=salt-minion
  DAEMON=/usr/bin/salt-minion
-DAEMON_ARGS="-d"
+DAEMON_ARGS=""
  PIDFILE=/var/run/$NAME.pid
  SCRIPTNAME=/etc/init.d/$NAME

---

From: Mark Hindley <[email-masked]>
Date: Wed, 3 Feb 2021 17:35:37 +0000

Control: tags -1 moreinfo, debian

Samuli,

Thanks for this.

> In /etc/init.d/salt-minion , the line
[...]
> . In Debian Buster the salt-minion service is also launched without the -d
> argument.

Devuan uses the Debian package of salt-minion directly without recompilation, so
if this line is not present in the Buster version of the initscript, I wonder if
you might have edited the file yourself at some point?

Mark

---

From: Mark Hindley <[email-masked]>
Date: Wed, 3 Feb 2021 17:44:03 +0000

On Wed, Feb 03, 2021 at 05:35:38PM +0000, Mark Hindley wrote:
> Devuan uses the Debian package of salt-minion directly without recompilation,
> so if this line is not present in the Buster version of the initscript, I
> wonder if you might have edited the file yourself at some point?

Actually, I should have looked first. AFAICS, it is present in the
salt-minion_2018.3.4+dfsg1-6+deb10u2_all.deb initscript at line 18.

So this is a Debian bug. Please report it (together with your patch) directly to
Debian's BTS.

Thanks

Mark

---

From: Samuli Airaksinen <[email-masked]>
Date: Thu, 4 Feb 2021 06:49:11 +0200

> salt-minion_2018.3.4+dfsg1-6+deb10u2_all.deb initscript at line 18.

Apologies, so it seems. I only looked at the systemd service files and 
didn't realize there is /etc/init.d/salt-minion in the Debian version as 
well.

Please close this bug as WONTFIX or similar. At least someone may find 
this later and get the tip they need to get salt-minion running in their 
Devuan.

Again, thanks and apologies.

-Samuli

---

From: Mark Hindley <[email-masked]>
Date: Thu, 4 Feb 2021 10:47:33 +0000

> didn't realize there is /etc/init.d/salt-minion in the Debian version as

No worries.

> Please close this bug as WONTFIX or similar. At least someone may find this
> later and get the tip they need to get salt-minion running in their Devuan.

Actually, I would rather get this fixed in Debian, if possible. Would you mind
sending your report to [email-masked] with the patch? It might get
fixed.

Thanks

Mark

---

From: Mark Hindley <[email-masked]>
Date: Fri, 3 Feb 2023 11:28:19 +0000

Control: forwarded -1 https://bugs.debian.org/1030345

> sending your report to [email-masked] with the patch? It might get

I have forwarded this to Debian's BTS.

Mark

---

From: "Devuan bug Tracking System" <[email-masked]>
Date: Wed, 24 Apr 2024 16:12:02 +0000

This is an automatic notification regarding your bug report
which was filed against the salt-minion package:

#543: DAEMON_ARGS in /etc/init.d/salt-minion prevents salt-minion startup

It has been closed by Mark Hindley <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mark Hindley <[email-masked]> by
replying to this email.

-- 
543: https://bugs.devuan.org/cgi/bugreport.cgi?bug=543
Devuan Bug Tracking System
Contact [email-masked] with problems

Subject: Closed in Debian #1030345
From: Mark Hindley <[email-masked]>
To: [email-masked]
Date: Wed, 24 Apr 2024 17:09:35 +0100

Package removed from Debian.

Closing.

Mark

Subject: DAEMON_ARGS in /etc/init.d/salt-minion prevents salt-minion startup
From: Samuli Airaksinen <[email-masked]>
To: [email-masked]
Date: Wed, 3 Feb 2021 18:27:14 +0200

Package: salt-minion

DAEMON_ARGS="-d"

Proposed patch:

@@ -15,7 +15,7 @@