salt-minion prevents salt-minion startup

Package: salt-minion; Maintainer for salt-minion is (unknown); Source for salt-minion is src:salt.

Reported by: Samuli Airaksinen <devuan@airasa.fi>

Date: Wed, 3 Feb 2021 16:33:01 UTC

Severity: normal

Tags: debian, moreinfo

Found in version 2018.3.4+dfsg1-6+deb10u2

Done: Mark Hindley <mark@hindley.org.uk>

Forwarded to https://bugs.debian.org/1030345

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.devuan.org
Subject: bug#543: DAEMON_ARGS in /etc/init.d/salt-minion prevents salt-minion startup
Reply-To: Samuli Airaksinen <devuan@airasa.fi>, 543@bugs.devuan.org
Resent-From: Samuli Airaksinen <devuan@airasa.fi>
Resent-To: devuan-bugs@lists.dyne.org
Resent-CC: devuan-dev@lists.dyne.org
X-Loop: owner@bugs.devuan.org
Resent-Date: Wed, 03 Feb 2021 16:33:01 +0000
Resent-Message-ID: <handler.543.B.16123698025006@bugs.devuan.org>
Resent-Sender: owner@bugs.devuan.org
X-Devuan-PR-Message: report 543
X-Devuan-PR-Package: salt-minion
X-Devuan-PR-Keywords: 
Received: via spool by submit@bugs.devuan.org id=B.16123698025006
          (code B); Wed, 03 Feb 2021 16:33:01 +0000
Received: (at submit) by bugs.devuan.org; 3 Feb 2021 16:30:02 +0000
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Wed, 03 Feb 2021 16:30:02 +0000 (UTC)
Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171])
	(using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id 3B64CF60B76
	for <submit@bugs.devuan.org>; Wed,  3 Feb 2021 17:27:20 +0100 (CET)
Authentication-Results: vm6.ganeti.dyne.org;
	dkim=pass (2048-bit key; unprotected) header.d=airasa.fi header.i=@airasa.fi header.b="tAyWy7lc";
	dkim-atps=neutral
Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4DW6XQ1n27zQlYP
	for <submit@bugs.devuan.org>; Wed,  3 Feb 2021 17:27:18 +0100 (CET)
X-Virus-Scanned: amavisd-new at heinlein-support.de
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airasa.fi; s=MBO0001;
	t=1612369636;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=fMy4qyFvuAXfvQrpfFrHdExobck/nROauKkicPniSGM=;
	b=tAyWy7lcn/XVyImb2d29n8Qje3I4DKSp1C9fU0JvqK+YYsbE3dUMA4gYEF52X2SxjBFCQS
	beQc6cDQZ+sDPIF8O3q2cOG143Iop5WjOwz1QxYFO20ZIYCda+FR6FpyFEg8FlhY/G8jQL
	AWI0R2sDm60yXbA1lHdr9OCkCJzvPInAXWP0H6qqFf4WqwwwtW8KsbAAddVm293Yxz9SC5
	CCydsLTyv6i4riyGGLl0Km4Hrq3A5yGtZM5pvCw3f5D4KUtwOukyrR3gf/4ZueOSW7ccLx
	euZbBlVBBhVA2FmLTh3qIF9Xj5KLLiOwNnYqOE/7S2oqij0/Yuv63bjY3lSMBg==
Received: from smtp2.mailbox.org ([80.241.60.241])
	by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030)
	with ESMTP id vueX8_MsyI61 for <submit@bugs.devuan.org>;
	Wed,  3 Feb 2021 17:27:14 +0100 (CET)
From: Samuli Airaksinen <devuan@airasa.fi>
To: submit@bugs.devuan.org
Message-ID: <835a127b-e5ed-9914-780f-92057214c325@samuliairaksinen.fi>
Date: Wed, 3 Feb 2021 18:27:14 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -4.51 / 15.00 / 15.00
X-Rspamd-Queue-Id: 06EF517D9
X-Rspamd-UID: 658ab2
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

Package: salt-minion
Version: 2018.3.4+dfsg1-6+deb10u2

In /etc/init.d/salt-minion , the line

DAEMON_ARGS="-d"

causes the minion to freeze upon startup. The -d switch, which runs the 
minion in the background, is ok when /usr/bin/salt-minion is ran 
interactively, but causes the minion to freeze when launched via service.

The switch is also warned against at 
https://ansible-cn.readthedocs.io/en/latest/topics/troubleshooting/minion.html 
. In Debian Buster the salt-minion service is also launched without the 
-d argument.

There is no error message. The last log message in log_levels "trace" 
and "garbage" is: "Getting lsb_release distro information", after which 
the minion remains unresponsive.

Emptying the DAEMON_ARGS fixes the problem and enables salt-minion to 
start properly.


Proposed patch:

@@ -15,7 +15,7 @@
 DESC="salt minion control daemon"
 NAME=salt-minion
 DAEMON=/usr/bin/salt-minion
-DAEMON_ARGS="-d"
+DAEMON_ARGS=""
 PIDFILE=/var/run/$NAME.pid
 SCRIPTNAME=/etc/init.d/$NAME

Send a report that this bug log contains spam.

Devuan bug report logs - #543 DAEMON_ARGS in /etc/init.d/salt-minion prevents salt-minion startup

Devuan bug report logs - #543
DAEMON_ARGS in /etc/init.d/salt-minion prevents salt-minion startup