Home | Devuan | Git | Forum | Packages | Popcon
Donate now!
Download

Devuan bug report logs - #599
initscripts: typo in /etc/init.d/sendsigs (easy fix)

version graph

Package: initscripts; Maintainer for initscripts is Devuan Developers <devuan-dev@lists.dyne.org>; Source for initscripts is src:sysvinit.

Reported by: Jerome BENOIT <calculus@nylyn.rezozer.net>

Date: Sat, 7 Aug 2021 17:32:01 UTC

Severity: normal

Tags: moreinfo

Found in version 2.93-8+devuan1

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.devuan.org
Subject: bug#599: initscripts: typo in /etc/init.d/sendsigs (easy fix)
Reply-To: calculus@rezozer.net, 599@bugs.devuan.org
Resent-From: Jerome BENOIT <calculus@rezozer.net>
Resent-To: devuan-bugs@lists.dyne.org
Resent-CC: Devuan Developers <devuan-dev@lists.dyne.org>
X-Loop: owner@bugs.devuan.org
Resent-Date: Sun, 08 Aug 2021 12:42:07 +0000
Resent-Message-ID: <handler.599.B599.16284264035549@bugs.devuan.org>
Resent-Sender: owner@bugs.devuan.org
X-Devuan-PR-Message: followup 599
X-Devuan-PR-Package: initscripts
X-Devuan-PR-Keywords: moreinfo
References: <162835699765.5084.16710644229743945299.reportbug@qubbuq.rezozer.net> <YQ7PvPjW+mFYRmOu@hindley.org.uk> <YQ7PvPjW+mFYRmOu@hindley.org.uk> <162835699765.5084.16710644229743945299.reportbug@qubbuq.rezozer.net> <31e56d8a-15ce-b1d9-a816-634637df751a@rezozer.net> <YQ997//OHxF7zDqI@hindley.org.uk> <YQ9/cfQyV7zYWi2u@hindley.org.uk> <YQ9/cfQyV7zYWi2u@hindley.org.uk> <162835699765.5084.16710644229743945299.reportbug@qubbuq.rezozer.net>
Received: via spool by 599-submit@bugs.devuan.org id=B599.16284264035549
          (code B ref 599); Sun, 08 Aug 2021 12:42:07 +0000
Received: (at 599) by bugs.devuan.org; 8 Aug 2021 12:40:03 +0000
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Sun, 08 Aug 2021 12:40:03 +0000 (UTC)
Received: from outmail148113.authsmtp.com (outmail148113.authsmtp.com [62.13.148.113])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id 6F3A0F6090F
	for <599@bugs.devuan.org>; Sun,  8 Aug 2021 14:37:01 +0200 (CEST)
Received: from punt23.authsmtp.com (punt23.authsmtp.com [62.13.128.122])
	by punt15.authsmtp.com. (8.15.2/8.15.2) with ESMTP id 178Cb0x3095743
	for <599@bugs.devuan.org>; Sun, 8 Aug 2021 13:37:00 +0100 (BST)
	(envelope-from calculus@rezozer.net)
Received: from mail-c233.authsmtp.com (mail-c233.authsmtp.com [62.13.128.233])
	by punt23.authsmtp.com. (8.15.2/8.15.2) with ESMTP id 178Cb0N1070890
	for <599@bugs.devuan.org>; Sun, 8 Aug 2021 13:37:00 +0100 (BST)
	(envelope-from calculus@rezozer.net)
Received: from nen.rezozer.net (aub23-1-78-246-96-191.fbx.proxad.net [78.246.96.191])
	(authenticated bits=0)
	by mail.authsmtp.com (8.15.2/8.15.2) with ESMTPSA id 178Caw6W083780
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)
	for <599@bugs.devuan.org>; Sun, 8 Aug 2021 13:36:58 +0100 (BST)
	(envelope-from calculus@rezozer.net)
Received: from [127.0.0.1]
	by nen.rezozer.net with esmtp (Exim 4.92)
	(envelope-from <calculus@rezozer.net>)
	id 1mCi30-00057b-9j
	for 599@bugs.devuan.org; Sun, 08 Aug 2021 14:36:58 +0200
To: 599@bugs.devuan.org
From: Jerome BENOIT <calculus@rezozer.net>
Organization: ReZoZeR
Message-ID: <7369f1c3-9b21-0217-e39f-803e9a8ec033@rezozer.net>
Date: Sun, 8 Aug 2021 14:36:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YQ9/cfQyV7zYWi2u@hindley.org.uk>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="lfZeAzlYGdZrvj1WFgI7TIILh5KBB7iU0"
X-Server-Quench: 52c6801d-f845-11eb-a0f2-84349711df28
X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse
X-AuthRoute: OCdyYgsWA1ZeRQAR FycZFwdaRBciNBBW RxkOMR0HcQshXxle KQBWI0ROOVtaQktW TWYDRCURB0JzWWF0 ewtSZwZbaE9HEQJi TkpNRExbEhtpCB0e AxYZTRg8dgJOCy83 YyFiVnNcVEQ0ckR/ QwBRFz4AbWdhPH1J WERdagJVJVFXLx8T aE13UHAJaGIGZy42 RV8lBT1jdT9CJ28I E1BfZVMUQFoQFSQ9 XwwZT30zDFUCDyQ1 Z1srNlVbHUAQLgM+ dkAsX14DMhAJQk1T FlpcSCFYNxhp
X-Authentic-SMTP: 61633132333330.1021:7600
X-AuthFastPath: 0 (Was 255)
X-AuthVirus-Status: No virus detected - but ensure you scan with your own anti-virus system.
X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

[Message part 1 (text/plain, inline)]
Hello Mark, thanks for pointing me to /usr/share/doc/initscripts/README.Debian .
I am sorry I could not find the commit you reference to.

Indeed the current script fulfills the policy in the above README.Debian .

I would however make the minor change in the first loop [ -e $omitfile ] to [ -f $omitfile ] to make clearer
that a file is expected (see patch 599_bugs_devuan_org-sendsigs-filetest.patch )

Having said that I think that making loops over one element is rather confusing
and it deserves some explanation if it must be kept it that way
(see patch 599_bugs_devuan_org-sendsigs-lessconfusing.patch ).

Cheers,
Jerome

-- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B

[599_bugs_devuan_org-sendsigs-filetest.patch (text/x-patch, attachment)]
[599_bugs_devuan_org-sendsigs-lessconfusing.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.

Devuan Bugs Owner <owner@bugs.devuan.org>.
Last modified: Mon Nov 25 04:22:51 2024;