sendsigs (easy fix)

Package: initscripts; Maintainer for initscripts is Devuan Developers <devuan-dev@lists.dyne.org>; Source for initscripts is src:sysvinit.

Reported by: Jerome BENOIT <calculus@nylyn.rezozer.net>

Date: Sat, 7 Aug 2021 17:32:01 UTC

Severity: normal

Tags: moreinfo

Found in version 2.93-8+devuan1

Full log

🔗 View this message in rfc822 format

Subject: bug#599: initscripts: typo in /etc/init.d/sendsigs (easy fix)
Reply-To: Mark Hindley <mark@hindley.org.uk>, 599@bugs.devuan.org
Resent-From: Mark Hindley <mark@hindley.org.uk>
Resent-To: devuan-bugs@lists.dyne.org
Resent-CC: Devuan Developers <devuan-dev@lists.dyne.org>
Resent-Date: Sat, 07 Aug 2021 18:32:01 +0000
Resent-Message-ID: <handler.599.B599.162836100429455@bugs.devuan.org>
Resent-Sender: owner@bugs.devuan.org
References: <162835699765.5084.16710644229743945299.reportbug@qubbuq.rezozer.net> <162835699765.5084.16710644229743945299.reportbug@qubbuq.rezozer.net>
Date: Sat, 7 Aug 2021 19:23:56 +0100
From: Mark Hindley <mark@hindley.org.uk>
To: Jerome BENOIT <calculus@nylyn.rezozer.net>, 599@bugs.devuan.org
Message-ID: <YQ7PvPjW+mFYRmOu@hindley.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <162835699765.5084.16710644229743945299.reportbug@qubbuq.rezozer.net>

Control: tags -1 moreinfo

Jerome,

Thanks for this.

On Sat, Aug 07, 2021 at 05:23:17PM +0000, Jerome BENOIT wrote:
> Package: initscripts
> Version: 2.93-8+devuan1
> Severity: normal
> 
> Dear Maintainer,
> 
> 	In the /etc/init.d/sendsigs script, at the beginning of function
> 	do_stop(), in the for-loop, the in-argument seems to be mispelled:
> 	the terminal '.d' is missing.

Hmmm, I am not so sure about this.
 
> do_stop () {
> 	OMITPIDS=
> 
> 	for omitfile in /run/sendsigs.omit; do

I think this is where you think the typo is ^^^^?

Isn't this legacy handling for /run/sendsigs.omit? Admittedly that file is not
present on my beowulf system..

> 		if [ -e $omitfile ]; then

.. so this is skipped.

> 			for pid in $(cat $omitfile); do
> 				OMITPIDS="${OMITPIDS:+$OMITPIDS }-o $pid"
> 			done
> 		fi
> 	done
> 
> 	# Load sendsigs.omit.d/packagename files too, to make it
> 	# possible for scripts that need to modify the list of pids at
> 	# run time without race conditions.
> 	for omitdir in /run/sendsigs.omit.d; do

Files in /run/sendsigs.omit.d/ are handled here.

> 		if [ -d "${omitdir}" ]; then
> 			for pidfile in "${omitdir}/"*; do
> 				[ -f "$pidfile" ] || continue
> 				for pid in $(cat $pidfile); do
> 					OMITPIDS="${OMITPIDS:+$OMITPIDS }-o $pid"
> 				done
> 			done
> 		fi
> 	done

Or have I misunderstood you?

Thanks

Mark

Send a report that this bug log contains spam.

Devuan bug report logs - #599 initscripts: typo in /etc/init.d/sendsigs (easy fix)

Devuan bug report logs - #599
initscripts: typo in /etc/init.d/sendsigs (easy fix)