Devuan bug report logs - #697
/etc/default/grub.d/xen.cfg: Extraneous output line causes error message at boot

version graph

Package: xen-hypervisor-common; Maintainer for xen-hypervisor-common is (unknown); Source for xen-hypervisor-common is src:xen.

Reported by: "John E. Krokes" <mag@netherworld.org>

Date: Tue, 2 Aug 2022 09:06:02 UTC

Severity: minor

Tags: debian

Found in version 4.14.5+24-g87d90d511c-1

Fixed in version 4.16.2-1

Done: Mark Hindley <mark@hindley.org.uk>

Forwarded to https://bugs.debian.org/1016547

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to devuan-bugs@lists.dyne.org, devuan-dev@lists.dyne.org:
bug#697; Package xen-hypervisor-common. (Tue, 02 Aug 2022 09:06:02 GMT) (full text, mbox, link).


Acknowledgement sent to "John E. Krokes" <mag@netherworld.org>:
New bug report received and forwarded. Copy sent to devuan-dev@lists.dyne.org. (Tue, 02 Aug 2022 09:06:07 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.devuan.org (full text, mbox, reply):

From: "John E. Krokes" <mag@netherworld.org>
To: Devuan Bug Tracking System <submit@bugs.devuan.org>
Subject: /etc/default/grub.d/xen.cfg: Extraneous output line causes error message at boot
Date: Mon, 01 Aug 2022 16:41:53 -0400
Package: xen-hypervisor-common
Version: 4.14.5+24-g87d90d511c-1
Severity: minor
File: /etc/default/grub.d/xen.cfg

Dear Maintainer,

When invoked via grub-mkconfig, xen.cfg outputs this as its first line:
        Including Xen overrides from /etc/default/grub.d/xen.cfg

The output of grub-mkconfig is expected to be redirected into a grub.cfg file.
Grub will read the grub.cfg at boot. Unfortunately, "Including" is not a
valid grub command. So when booting, grub emits this error message before
displaying its menu:
	error: can't find command `Including'.


The error message is obscured very quickly. It does not affect functionality
in any way. It requires booting on a VERY slow machine in order to read
the error message at all.


If I add a '#' to the start of the "Including", the resulting grub config file
boots with no error.
	echo "#Including Xen overrides from /etc/default/grub.d/xen.cfg"


I'm not sure if this line was intended to go into the generated config
file as a comment, or if it was intended to be shown to the user while
grub-mkconfig is running.


I have observed this and tested my fix against version
4.14.5+24-g87d90d511c-1 of xen-hypervisor-common. I have also checked
with the debian git at https://salsa.debian.org/xen-team/debian-xen/-/blob/master/debian/tree/xen-hypervisor-common/etc/default/grub.d/xen.cfg. This line
has not changed in a very long time.


I can also duplicate the behavior using grub-emu, with the output redirected
to a file.



Thanks for your time.

-Mag


-- System Information:
Distributor ID:	Devuan
Description:	Devuan GNU/Linux 4 (chimaera)
Release:	4
Codename:	chimaera
Architecture: x86_64

Kernel: Linux 5.10.0-16-amd64 (SMP w/2 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

-- Configuration Files:
/etc/default/grub.d/xen.cfg changed:
echo "Including Xen overrides from /etc/default/grub.d/xen.cfg"
XEN_OVERRIDE_GRUB_DEFAULT=0
if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "" ]; then
	echo "WARNING: GRUB_DEFAULT changed to boot into Xen by default!"
	echo "         Edit /etc/default/grub.d/xen.cfg to avoid this warning."
	XEN_OVERRIDE_GRUB_DEFAULT=1
fi
if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "1" ]; then
	GRUB_DEFAULT=$( \
		printf "$(gettext "%s, with Xen hypervisor")" \
		"$GRUB_DISTRIBUTOR GNU/Linux")
fi


-- no debconf information

Information forwarded to devuan-bugs@lists.dyne.org, devuan-dev@lists.dyne.org:
bug#697; Package xen-hypervisor-common. (Tue, 02 Aug 2022 15:52:02 GMT) (full text, mbox, link).


Message #8 received at 697@bugs.devuan.org (full text, mbox, reply):

From: Mark Hindley <mark@hindley.org.uk>
To: "John E. Krokes" <mag@netherworld.org>, 697@bugs.devuan.org
Subject: Re: bug#697: /etc/default/grub.d/xen.cfg: Extraneous output line causes error message at boot
Date: Tue, 2 Aug 2022 16:50:29 +0100
Control: tags -1 debian

John,

Thanks.

On Mon, Aug 01, 2022 at 04:41:53PM -0400, John E. Krokes wrote:
> Package: xen-hypervisor-common
> Version: 4.14.5+24-g87d90d511c-1
> Severity: minor
> File: /etc/default/grub.d/xen.cfg

Neither grrub nor xen are forked in Devuan and we use Debian's packages directly
without recompilation. Please report this issue to Debian's BTS to be addressed.

Thanks

Mark

Added tag(s) debian. Request was from Mark Hindley <mark@hindley.org.uk> to 697-submit@bugs.devuan.org. (Tue, 02 Aug 2022 15:52:07 GMT) (full text, mbox, link).


Set bug forwarded-to-address to 'https://bugs.debian.org/1016547'. Request was from Mark Hindley <mark@hindley.org.uk> to control@bugs.devuan.org. (Wed, 11 Jan 2023 10:04:01 GMT) (full text, mbox, link).


Reply sent to Mark Hindley <mark@hindley.org.uk>:
You have taken responsibility. (Wed, 11 Jan 2023 10:10:02 GMT) (full text, mbox, link).


Notification sent to "John E. Krokes" <mag@netherworld.org>:
bug acknowledged by developer. (Wed, 11 Jan 2023 10:10:05 GMT) (full text, mbox, link).


Message #17 received at 697-done@bugs.devuan.org (full text, mbox, reply):

From: Mark Hindley <mark@hindley.org.uk>
To: 697-done@bugs.devuan.org
Subject: Fixed in Debian #1016547
Date: Wed, 11 Jan 2023 10:08:27 +0000
Version: 4.16.2-1

Send a report that this bug log contains spam.


Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.

Devuan Bugs Owner <owner@bugs.devuan.org>.
Last modified: Fri Mar 29 14:17:16 2024;