Devuan bug report logs - #761
slim: label position in slimlock vs. slim (fix included)

version graph

Package: slim; Maintainer for slim is Devuan Dev Team <devuan-dev@lists.dyne.org>; Source for slim is src:slim.

Reported by: tom314@posteo.net

Date: Thu, 8 Jun 2023 23:14:01 UTC

Severity: normal

Found in version slim/1.4.0-0devuan2

Fixed in version 1.4.0-0devuan3

Done: dak@devuan.org

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to devuan-bugs@lists.dyne.org, Devuan Dev Team <devuan-dev@lists.dyne.org>:
bug#761; Package slim. (Thu, 08 Jun 2023 23:14:02 GMT) (full text, mbox, link).


Acknowledgement sent to tom314@posteo.net:
New bug report received and forwarded. Copy sent to Devuan Dev Team <devuan-dev@lists.dyne.org>. (Thu, 08 Jun 2023 23:14:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.devuan.org (full text, mbox, reply):

From: tom314@posteo.net
To: submit@bugs.devuan.org
Subject: slim: label position in slimlock vs. slim (fix included)
Date: Thu, 08 Jun 2023 23:11:06 +0000
[Message part 1 (text/plain, inline)]
package: slim
version: 1.4.0-0devuan2

slimlock shows two text-labels (welcome_ and password_). Placement is 
relative background, but should be relativepanel-image, like slim.
This is invisible when using a current Devuan theme(s): The panel-image 
is placed at 0,0, which equalises the origins in slim and slimlock.
Fix: small patch included, mostly comments in the source as patch-notes. 
Maintainers may use it as they see fit.
Patch file: 
"slim__slimlock_label_positions__welcome_and_password__bugfix.patch"

System: daedalus
Kernel: 6.3.6-1-liquorix-amd64
((chimaera's 1.3.6: Patch applies with comments rejected. Seems to work 
for welcome_ and username_ (not hidden), but not for password_)).


Part II:
Dear maintainer,
beside the bug fix, there is a small piece of code to handle in-line 
comments in config files, which is attached too.

Proposed feature: Handle in-line comments in config files (slim.theme).
Reason: Before realising the error, I used in-line comments during 
theme'ing.
Patch file: "slim__in-line_comments_in_config_files__addon.patch"
This may or may not be considered useful.


Both are tested, but I'm not really a software developer.
Feel free to contact me for any issues.

Thanks for devuan, slim and all the effort!
Regards,
Thomas
[slim__slimlock_label_positions__welcome_and_password__bugfix.patch (text/x-patch, attachment)]
[slim__in-line_comments_in_config_files__addon.patch (text/x-patch, attachment)]

Reply sent to dak@devuan.org:
You have taken responsibility. (Fri, 11 Aug 2023 03:36:02 GMT) (full text, mbox, link).


Notification sent to tom314@posteo.net:
bug acknowledged by developer. (Fri, 11 Aug 2023 03:36:03 GMT) (full text, mbox, link).


Message #10 received at 761-done@bugs.devuan.org (full text, mbox, reply):

From: dak@devuan.org
To: 761-done@bugs.devuan.org
Subject: #761: fixed in src:slim version 1.4.0-0devuan3
Date: Fri, 11 Aug 2023 03:33:32 +0000
Version: 1.4.0-0devuan3

Source package slim (1.4.0-0devuan3) added to Devuan suite unstable.

This closes bug report 761.

Thanks

DAK managing the Devuan archive

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 11 Aug 2023 02:51:09 +0000
Source: slim
Architecture: source
Version: 1.4.0-0devuan3
Distribution: unstable
Urgency: medium
Maintainer: Devuan Dev Team <devuan-dev@lists.dyne.org>
Changed-By: Boian Bonev <bbonev@devuan.org>
Closes: 761
Changes:
 slim (1.4.0-0devuan3) unstable; urgency=medium
 .
   [ Thomas Fischer ]
   * PR#7 by Thomas Fischer <tom314@posteo.net>
     - Move text labels to the correct position as in slim (slimlock,
       Closes: #761)
     - Allow inline comments in config files
     - Fix background image with alpha channel stretch/tile/center and
       background color
 .
   [ Boian Bonev ]
   * Upload to unstable
Checksums-Sha1:
 91821c7a2f9b3bd4a00e4c9e17c898a6339f7015 1814 slim_1.4.0-0devuan3.dsc
 aab520673e4196e704535361459286d817d55836 34656 slim_1.4.0-0devuan3.debian.tar.xz
 e1e89f42989ff4f369a9596a4dc7a94a8267b632 5373 slim_1.4.0-0devuan3_source.buildinfo
Checksums-Sha256:
 627c89b8adbe65e0c7992540e226d47b4048939c2405bbcee0ec57bdcdef9c6f 1814 slim_1.4.0-0devuan3.dsc
 0d63d6536ccb21b5633f5a7e4bd400339168a62418904a2b3d2d31764da1030d 34656 slim_1.4.0-0devuan3.debian.tar.xz
 c1c0fb1c639e97244eccb0bb182ab1fde5c3f3e256a4554d588dde46a1e5b28b 5373 slim_1.4.0-0devuan3_source.buildinfo
Files:
 b808a2d3aef9dfe4b4e39fdea51d5a32 1814 x11 optional slim_1.4.0-0devuan3.dsc
 02280819d9dd1d65505aeccb9eda11a2 34656 x11 optional slim_1.4.0-0devuan3.debian.tar.xz
 38d004bb362854566d90ab1def79651a 5373 x11 optional slim_1.4.0-0devuan3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEcuPLdzMV36LkZHQ9lFMhJFQZIvsFAmTVp9gACgkQlFMhJFQZ
IvvXTQf+O4IKpjNephIenaWLI2KpVTGtC1urNCLkXYA7obJDt3JhD2IBSqGXeOZn
VhhpCaB6oY97zCtAeRcVXSpbfKzL65JMr7d47pgPwpLknntp864TlsdT79t8ZB7O
xEQvDAdsYhgpV+eKY6iaZS/clsmpsvRggsOV2F5jKoOBsUbq6iSvWomFBpPogfF1
yOk7CWm47Lx17Ssvapvj/1JGWcgZW6T1+2nqyyxBkrvhdJ2hciaOMSZtxuw8Yo6Z
OyJljNPKrE7KuEfK0gD3PFlMZYQgLMj2IS+uKolS73BRIHjh261dPW0iHgOl+Twe
WdsfkmLEYIHGe3X977iY18L9+9dkow==
=E00J
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.


Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.

Devuan Bugs Owner <owner@bugs.devuan.org>.
Last modified: Sun Nov 24 14:07:25 2024;