lighttpd: Questionable use of invoke-rc.d

Package: init-system-helpers; Maintainer for init-system-helpers is Devuan Dev Team <devuan-dev@lists.dyne.org>; Source for init-system-helpers is src:init-system-helpers.

Reported by: Opty <opty77@gmail.com>

Date: Tue, 1 Apr 2025 12:44:01 UTC

Severity: normal

Tags: debian, moreinfo

Merged with 881, 883, 884

Found in version init-system-helpers/1.65.2devuan1

Done: Mark Hindley <mark@hindley.org.uk>

Full log

Message #50 received at 881-done@bugs.devuan.org (full text, mbox, reply):

Received: (at 881-done) by bugs.devuan.org; 6 Apr 2025 08:37:41 +0000
Return-Path: <mark@hindley.org.uk>
Delivered-To: bugs@devuan.org
Received: from email.devuan.org [2a01:4f9:fff1:13::5fd9:f9e4]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Sun, 06 Apr 2025 08:37:41 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 88v1HD898metawAAmSBk0A
	(envelope-from <mark@hindley.org.uk>)
	for <bugs@devuan.org>; Sun, 06 Apr 2025 08:37:19 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id 3F43D585; Sun,  6 Apr 2025 08:37:19 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; envelope-from=mark@hindley.org.uk; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 7001B37
	for <881-done@bugs.devuan.org>; Sun,  6 Apr 2025 08:37:17 +0000 (UTC)
Received: from hindley.org.uk (apollo.hindleynet [192.168.1.3])
	by mx.hindley.org.uk (Postfix) with SMTP id 03CF991;
	Sun,  6 Apr 2025 09:37:16 +0100 (BST)
Received: (nullmailer pid 23735 invoked by uid 1000);
	Sun, 06 Apr 2025 08:37:14 -0000
Date: Sun, 6 Apr 2025 09:37:14 +0100
From: Mark Hindley <mark@hindley.org.uk>
To: Opty <opty77@gmail.com>
Cc: 881-done@bugs.devuan.org
Subject: Re: bug#881: invoke-rc.d: Policy layer may override runlevel
 constraint
Message-ID: <Z_I9OoxRWQWrCk8F@hindley.org.uk>
References: <CAERDJOGBvwgsTJ7rL-MaUqLmBk7kBd12rtuAj1hDQt0-U9Ktug@mail.gmail.com>
 <Z-wTFqfiCrvD9Exb@hindley.org.uk>
 <CAERDJOG_4mnRRA7oFvcbMFoiZitExizd=jR=HqyL9dT15ORFyQ@mail.gmail.com>
 <Z-1gvG_pT6x0FsRf@hindley.org.uk>
 <CAERDJOGezboa6AzE9oJt-JKPtqEiE97fJ8DPapPmCxQhjCBTJw@mail.gmail.com>
 <Z-4u39maG54wqFRF@hindley.org.uk>
 <CAERDJOG2SLOG-=ouK4QwDc_-d4CQz=Maf1yRO9-1ioBvYhuWBw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAERDJOG2SLOG-=ouK4QwDc_-d4CQz=Maf1yRO9-1ioBvYhuWBw@mail.gmail.com>

Opty,

Thanks,

On Thu, Apr 03, 2025 at 01:16:40PM +0200, Opty wrote:
> > That isn't conventional Debian practice.
> 
> I could continue using the policy layer unmodified, selectively allow
> what I need (extra work) and keep denied the rest
> 
> -or-
> 
> modify invoke-rc.d or rather policy-rc.d to check
> $DPKG_MAINTSCRIPT_NAME (to detect preinst, postinst, prerm or postrm
> script), crosscheck $DPKG_MAINTSCRIPT_PACKAGE vs. $INITSCRIPTID
> (substring of each other) to allow calling other scripts and
> eventually do nothing, maybe ask the administrator.
> 
> Both seem unintentional error- or side-effect-prone.
> 
> I could also just modify invoke-rc.d to skip the querypolicy call in
> case of K link.

I find it hard to see an actionable bug here. I think invoke-rc.d and
policy-rcd-declarative* are behaving as advertised. Your requirements appear
different to what policy-rcd-declarative-deny-all provides. So, as Simon
suggested, you need to write your own policy script to meet your requirements.

Therefore I will close this.

If you think I have missed something, please feel free to reopen.

Thanks

Mark

Send a report that this bug log contains spam.

Devuan bug report logs - #882 /etc/logrotate.d/lighttpd: Questionable use of invoke-rc.d

Devuan bug report logs - #882
/etc/logrotate.d/lighttpd: Questionable use of invoke-rc.d