Devuan bug report logs - #911
libpolkit-gobject-consolekit-1-0: Ships the elogind variant of the library

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.devuan.org (full text, mbox, reply):

Package: libpolkit-gobject-consolekit-1-0
Version: 0.105+26+devuan1
Severity: grave
Justification: ships the wrong shared-object library

Dear Maintainer,

Starting from version 0.105-26+devuan1, the
libpolkit-gobject-consolekit-1-0 package incorrectly ships the variant
of libpolkit-gobject-1.so.0.0.0 compiled with elogind session-tracking
rather than the variant compiled with ConsoleKit session-tracking. This
can be easily verified by comparing the checksums of the included
libpolkit-gobject-1.so.0.0.0 file in each of the
libpolkit-gobject-consolekit-1-0 and libpolkit-gobject-elogind-1-0
packages.


# Fix

Once this report is assigned a bug number, I will shortly be submitting
'git am'-ready patches to remedy this issue.


# Explanation

The issue lies with an interaction involving three commands in the
override_dh_install recipe in debian/rules, specifically
```
	dh_install -plibpolkit-gobject-consolekit-1-0 \
		--sourcedir=debian/install/consolekit
	dh_install -a -Nlibpolkit-gobject-consolekit-1-0
	[...]
	dh_install
```

The first command is required in order to copy the build of the
ConsoleKit variant of the library from its non-standard DESTDIR at
debian/install to the staging directory for the 
libpolkit-gobject-consolekit-1-0 binary package.

The second command then handles staging the files for the rest of the
arch-dependent packages, copying files from debian/tmp, the default
DESTDIR.

This leaves the third command with the task of staging the files for
all the remaining binary package which by this point should be all of
the arch-independent packages. However, because the command lacks
either a '-i' or '--remaining-packages' argument, it incorrectly stages
the files for *all* binary packages, copying files from only the
standard DESTDIR. This has the unfortunate consequence of re-staging
the libpolkit-gobject-consolekit-1-0 package, copying the elogind
variant of the library from within debian/tmp rather than the
ConsoleKit variant from debian/install.

-- 
Plasma

Message #10 received at 911@bugs.devuan.org (full text, mbox, reply):

Hi,

On 9/27/25 09:57, Plasma (David Paul) wrote:

> This leaves the third command with the task of staging the files for
> all the remaining binary package which by this point should be all of
> the arch-independent packages. However, because the command lacks
> either a '-i' or '--remaining-packages' argument, it incorrectly stages
> the files for *all* binary packages, copying files from only the
> standard DESTDIR.

Is that a Devuan specific change, or is that bug also present in the 
Debian package?

   Simon

Message #15 received at 911@bugs.devuan.org (full text, mbox, reply):

[Message part 1 (text/plain, inline)]

Control: tags -1 patch

Dear Maintainer,

Attached are two patches which fix #911. They can be applied to the
head of the suites/unstable branch in the policykit-1 packaging
repository. Please also consider backporting them into
excalibur-proposed for the upcoming Excalibur release.

-- 
Plasma

[0001-refactor-rules-Move-ubuntu-specific-snippet.patch (text/x-patch, attachment)]

[0002-Fix-override_dh_install-target.patch (text/x-patch, attachment)]

Message #22 received at 911@bugs.devuan.org (full text, mbox, reply):

On Sat, 27 Sep 2025 10:05:41 +0900
Simon Richter <sjr@debian.org> wrote:

> On 9/27/25 09:57, Plasma (David Paul) wrote:
> 
> > This leaves the third command with the task of staging the files for
> > all the remaining binary package which by this point should be all
> > of the arch-independent packages. However, because the command lacks
> > either a '-i' or '--remaining-packages' argument, it incorrectly
> > stages the files for *all* binary packages, copying files from only
> > the standard DESTDIR.  
> 
> Is that a Devuan specific change, or is that bug also present in the 
> Debian package?
> 
>     Simon

This is a Devuan-specific issue. Debian is unaffected by this bug, but
may wish to adopt a modified version of the refactor present in the
first of the two patches I submitted to resolve this Devuan issue.
Adapting the refactor patch for Debian may not be worth it though as,
apart from simplifying the second patch in the series, the refactor
patch borders on splitting hairs. See the attached commit message for
details.

-- 
Plasma

Message #31 received at 911@bugs.devuan.org (full text, mbox, reply):

Plasma,

Thanks for your analysis and care with this.

I prefer to resolve the first of your suggested patches by realigning more
closely with Debian's d/rules.

Mark

commit 2f09bfa62e597cbfb9385e2807c84db05cd68247
Author: Mark Hindley <mark@hindley.org.uk>
Date:   Mon Sep 29 15:05:08 2025 +0100

    d/rules: reduce unnecessary delta with Debian.

diff --git a/debian/rules b/debian/rules
index 8bba501e..152405ee 100755
--- a/debian/rules
+++ b/debian/rules
@@ -80,6 +80,14 @@ override_dh_auto_install:
 	dh_auto_install
 	dh_auto_install --builddirectory=build-consolekit --destdir=debian/install/consolekit
 
+execute_before_dh_install:
+	# on Debian use sudo group; on Ubuntu, also allow the admin group for
+	# on Debian/Devuan use sudo group; on Ubuntu, also allow the admin group for
+	# historical reasons
+	if dpkg-vendor --is ubuntu; then \
+		install -m644 debian/49-ubuntu-admin.rules debian/tmp/usr/share/polkit-1/rules.d/; \
+	fi
+
 override_dh_install:
 	dh_install \
 	-plibpolkit-gobject-consolekit-1-0       \
@@ -88,9 +96,4 @@ override_dh_install:
 	dh_install -a                           \
 	-Nlibpolkit-gobject-consolekit-1-0
 
-	# on Debian/Devuan use sudo group; on Ubuntu, also allow the admin group for
-	# historical reasons
-	if dpkg-vendor --is ubuntu; then \
-		install -m644 debian/49-ubuntu-admin.rules debian/tmp/usr/share/polkit-1/rules.d/; \
-	fi
 	dh_install

Message #36 received at 911-done@bugs.devuan.org (full text, mbox, reply):

Version: 126-2devuan2

Source package policykit-1 (126-2devuan2) added to Devuan suite unstable.

This closes bug report 911.

Thanks

DAK managing the Devuan archive

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 29 Sep 2025 15:22:55 +0100
Source: policykit-1
Architecture: source
Version: 126-2devuan2
Distribution: unstable
Urgency: medium
Maintainer: Devuan Dev Team <devuan-dev@lists.dyne.org>
Changed-By: Mark Hindley <mark@hindley.org.uk>
Closes: 911
Changes:
 policykit-1 (126-2devuan2) unstable; urgency=medium
 .
   [ Mark Hindley ]
   * d/rules: reduce unnecessary delta with Debian.
 .
   [ Plasma (David Paul) ]
   * d/rules: Fix override_dh_install target. (Closes: #911)
Checksums-Sha1:
 0604665a219468045bf27358d700e04433e5a90b 3098 policykit-1_126-2devuan2.dsc
 bd95db35c65cd7a002ba51f5e15544811f3d6c1a 33248 policykit-1_126-2devuan2.debian.tar.xz
 2ae138057876f3925d5cfdad4b13cc9cd94d5229 5605 policykit-1_126-2devuan2_source.buildinfo
Checksums-Sha256:
 f127374232886bb08375be80eef6da54bfdd84bb0011c7727719c886d9296f93 3098 policykit-1_126-2devuan2.dsc
 b54f18cd7301c33dad854c1ebc89310db81f06c136a98d302520a3c56920cb6e 33248 policykit-1_126-2devuan2.debian.tar.xz
 ccc970d867b4960ddd6f525523e4dc28ae45cc9b72c1e6e3ea8404325d6b488e 5605 policykit-1_126-2devuan2_source.buildinfo
Files:
 62a5a0a662cddff5e127ef165c7ce60f 3098 admin optional policykit-1_126-2devuan2.dsc
 d43afa04d5b2622dd9b6dbc2cf598e2e 33248 admin optional policykit-1_126-2devuan2.debian.tar.xz
 9e261c77119a4acdee1e0038d1517219 5605 admin optional policykit-1_126-2devuan2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEcuPLdzMV36LkZHQ9lFMhJFQZIvsFAmjaqqIACgkQlFMhJFQZ
Ivt9JAgAhVZuN3qnTFXfTWb37OBGlo2CvrJ59VPQi+27EdZKof97aH6lTCopHev9
gqC2MpKVFp/CTlqugQlLcqv902lfh1jjDMkuLdcbKowdcdKC7In9qUG6fRbyz5Ip
9NQe/skpNPt/ijKrgDwpk4pa/VN6WV5X49zVFsbT3n0xSmdtpOfJylOrD/ntRT9A
e17jDVGa8iMO6And44ugIVEw7YSfzNyUpau/nkO0jlnAifKLpu7lD/Peh6j1PaSm
MnLCIxSti9iuuWH0V/NSSJJ4xEyh7Fnc3CcfP6WDeR4EjY8kUWXWnP5E+lgLxNFL
ITmD/XkZDuYK4du3gA7icbeOP0lnRA==
=v0RS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.