Devuan bug report logs - #309
remove flag "-f" in pidof

Package: sysvinit-utils; Reported by: KatolaZ <katolaz@freaknet.org>; Done: KatolaZ <katolaz@freaknet.org>; Maintainer for sysvinit-utils is Devuan Developers <devuan-dev@lists.dyne.org>.

Message received at 309-done@bugs.devuan.org:


Received: (at 309-done) by bugs.devuan.org; 19 Mar 2019 06:40:05 +0000
Return-Path: <katolaz@freaknet.org>
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by fulcanelli with IMAP (fetchmail-6.3.26)
	for <debbugs@localhost> (single-drop); Tue, 19 Mar 2019 07:40:05 +0100 (CET)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	(Authenticated sender: katolaz@freaknet.org)
	with ESMTPSA id 65F76F6088C
Date: Tue, 19 Mar 2019 07:39:19 +0100
From: KatolaZ <katolaz@freaknet.org>
To: 309-done@bugs.devuan.org
Subject: sorry, wrong BTS
Message-ID: <20190319063919.2hujkfil4276z2cd@katolaz.homeunix.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="tuzy4pp6moump64x"
Content-Disposition: inline
User-Agent: NeoMutt/20170113 (1.7.2)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org


--tuzy4pp6moump64x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

This should have gone to bugs.debian.org. Sorry.

Closing

KatolaZ



--tuzy4pp6moump64x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQSOWdaqRF79tKFTPVpfILOuC18GLwUCXJCOlwAKCRBfILOuC18G
L2WYAJ0Vw/iufuvG4aGNcn+IktkDD7ZaYACcCLmv/ZVaS4j9P1OKTW3rsC06t7Q=
=Rlrf
-----END PGP SIGNATURE-----

--tuzy4pp6moump64x--


Notification sent to KatolaZ <katolaz@freaknet.org>:
bug acknowledged by developer. Full text available.
Reply sent to KatolaZ <katolaz@freaknet.org>:
You have taken responsibility. Full text available.

Message received at submit@bugs.devuan.org:


Received: (at submit) by bugs.devuan.org; 19 Mar 2019 06:30:04 +0000
Return-Path: <katolaz@freaknet.org>
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by fulcanelli with IMAP (fetchmail-6.3.26)
	for <debbugs@localhost> (single-drop); Tue, 19 Mar 2019 07:30:04 +0100 (CET)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	(Authenticated sender: katolaz@freaknet.org)
	with ESMTPSA id C36DDF60BD2
Date: Tue, 19 Mar 2019 07:29:11 +0100
From: KatolaZ <katolaz@freaknet.org>
To: submit@bugs.devuan.org
Subject: remove flag "-f" in pidof
Message-ID: <20190319062911.ffqz6ykwaihxrbe6@katolaz.homeunix.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="5uvpalol52xldhbj"
Content-Disposition: inline
User-Agent: NeoMutt/20170113 (1.7.2)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED
	autolearn=disabled version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org


--5uvpalol52xldhbj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: sysvinit-utils
Version: 2.93-8
Severity: normal

I am opening this bug because I think the recently added flag '-f' in
pidof should be removed. It was intended to be used as a way to format
the PIDs according to printf-style formatters, but accepting
unsanitised input from the user is quite dangerous, as shown in
#924792. The proposed solution to #924792 was to let pidof -f
interpret only '%d' and '\n'.

This is at least an unnecessary complication. pidof is already
printing the PIDs as integers (!), and any formatting can (but I would
say should/must) be done downstream by sed/awk/whatever. We can't add
a formatter to any single CLI command :\

Please remove the unneded '-f' flag. Unix is much much better than
that.

KatolaZ

--5uvpalol52xldhbj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQSOWdaqRF79tKFTPVpfILOuC18GLwUCXJCMNAAKCRBfILOuC18G
L6dKAJ9KOs2IoM71/3Ia4TuTxHxIaaPcyACfUhYw68q9RBRq+AsVnzwyqF2ir24=
=vgYs
-----END PGP SIGNATURE-----

--5uvpalol52xldhbj--


Acknowledgement sent to KatolaZ <katolaz@freaknet.org>:
New bug report received and forwarded. Copy sent to owner@bugs.devuan.org. Full text available.
Report forwarded to devuan-bugs@lists.dyne.org, owner@bugs.devuan.org:
bug#309; Package sysvinit-utils. Full text available.

Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.

Devuan Bugs Owner <owner@bugs.devuan.org>.
Last modified: Fri, 10 Jul 2020 16:39:01 UTC