Devuan bug report logs - #227
nbd-client: At shutdown nbd-client disabled before file-systems could be cleanly unmounted

Package: sysvinit-utils; Maintainer for sysvinit-utils is Devuan Developers <devuan-dev@lists.dyne.org>; Source for sysvinit-utils is src:sysvinit.

Affects: nbd-client

Reported by: David Kuehling <dvdkhlng@posteo.de>

Date: Mon, 16 Jul 2018 00:03:01 UTC

Severity: normal

Tags: upstream

Fixed in version 3.07-1

Done: Mark Hindley <mark@hindley.org.uk>

Full log

Message #24 received at 227@bugs.devuan.org (full text, mbox, reply):

Received: (at 227) by bugs.devuan.org; 16 Feb 2023 16:18:06 +0000
Return-Path: <mark@hindley.org.uk>
Delivered-To: bugs@devuan.org
Received: from email.devuan.org [2001:41d0:2:d06e::5c4:2612]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Thu, 16 Feb 2023 16:18:06 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 6vYOKzNX7mMdUQAAmSBk0A
	(envelope-from <mark@hindley.org.uk>)
	for <bugs@devuan.org>; Thu, 16 Feb 2023 16:17:55 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id A7204A0; Thu, 16 Feb 2023 16:17:55 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=0.4 required=5.0 tests=RDNS_DYNAMIC,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.36.131.86; helo=mx.hindley.org.uk; envelope-from=mark@hindley.org.uk; receiver=<UNKNOWN> 
Received: from mx.hindley.org.uk (193-36-131-86.cfwn.uk [193.36.131.86])
	by email.devuan.org (Postfix) with ESMTPS id 45C3723
	for <227@bugs.devuan.org>; Thu, 16 Feb 2023 16:17:55 +0000 (UTC)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <mark@hindley.org.uk>)
	id 1pSgxE-0006iS-KQ; Thu, 16 Feb 2023 16:17:52 +0000
Received: (nullmailer pid 27154 invoked by uid 1000);
	Thu, 16 Feb 2023 16:17:52 -0000
Date: Thu, 16 Feb 2023 16:17:52 +0000
From: Mark Hindley <mark@hindley.org.uk>
To: Jesse Smith <jsmith@resonatingmedia.com>
Cc: David Kuehling <dvdkhlng@posteo.de>, 227@bugs.devuan.org
Subject: Re: bug#227: nbd-client: At shutdown nbd-client disabled before
 file-systems could be cleanly unmounted
Message-ID: <Y+5XMAODvbjKHf/k@hindley.org.uk>
References: <87r2k4njjg.fsf@snail.snail.pool>
 <Y+5KRGlB5crallrj@hindley.org.uk>
 <e4623351-4e7c-3623-926d-1d08a0965278@resonatingmedia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e4623351-4e7c-3623-926d-1d08a0965278@resonatingmedia.com>

Control: reassign -1 sysvinit-utils
Control: affects -1 nbd-client

Jesse,

Thanks for you quick reply.

On Thu, Feb 16, 2023 at 11:54:32AM -0400, Jesse Smith wrote:
> I see two possible ways we could fix this:
> 
> 1. Create a command line flag which disables the SIGSTOP and SIGCONT
> signals being sent. This is an easy fix, quick and dirty. The potential
> downside is if someone disables the STOP signal then maybe processes
> terminate, move groups, or are replaced before we get around to sending
> them the KILL signal. This probably won't happen, but it means killall5
> is working with a "moving target".
> 
> 2. We can run SIGSTOP on all processes _except_ those in the omit list.
> This will be a lot slower than the existing "kill(-1, SIGSTOP)" call we
> currently make. But I think it's more correct.
> 
> Basically the new work flow would look like this:
> 
> 1. Send all processes except those omitted the SIGSTOP command.
> 2. Send all processes except those omitted the SIGKILL command.
> 3. Send all processes except those omitted the SIGCONT command.
> 
> Option #2 is slow and ugly, but seems "correct" from a behaviour point
> of view.

I don't really like #1: it will mean patching callers to get the (more?) correct
behaviour. So #2 seems better. Will it be significantly slower?. You could only
use it when omitpid is specified? If there are no omitpids, the current
behaviour seems fine.

Thanks

Mark

Send a report that this bug log contains spam.

Devuan bug report logs - #227 nbd-client: At shutdown nbd-client disabled before file-systems could be cleanly unmounted

Devuan bug report logs - #227
nbd-client: At shutdown nbd-client disabled before file-systems could be cleanly unmounted