Devuan bug report logs - #262
[atop] ..atop installs systemd cron job on non-systemd Devuan box...

Package: atop; Maintainer for atop is (unknown); Source for atop is src:atop.

Reported by: Arnt Karlsen <arnt@iaksess.no>

Date: Sun, 18 Nov 2018 02:03:01 UTC

Severity: normal

Tags: debian

Fixed in version 2.4.0-1

Done: Mark Hindley <mark@hindley.org.uk>

Forwarded to https://bugs.debian.org/913364

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.devuan.org
Subject: bug#262: ..fix: atop installs systemd cron job on non-systemd Devuan  box, was: Bug#913364: real bug, too low severity
Reply-To: Arnt Karlsen <arnt@iaksess.no>, 262@bugs.devuan.org
Resent-From: Arnt Karlsen <arnt@iaksess.no>
Resent-To: devuan-bugs@lists.dyne.org
Resent-CC: owner@bugs.devuan.org
Resent-Date: Mon, 11 Mar 2019 10:18:01 UTC
Resent-Message-ID: <handler.262.B262.155229900213897@bugs.devuan.org>
Resent-Sender: owner@bugs.devuan.org
X-Devuan-PR-Message: report 262
X-Devuan-PR-Package: atop
X-Devuan-PR-Keywords: 
Received: via spool by 262-submit@bugs.devuan.org id=B262.155229900213897
          (code B ref 262); Mon, 11 Mar 2019 10:18:01 UTC
Received: (at 262) by bugs.devuan.org; 11 Mar 2019 10:10:02 +0000
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by fulcanelli with IMAP (fetchmail-6.3.26)
	for <debbugs@localhost> (single-drop); Mon, 11 Mar 2019 11:10:02 +0100 (CET)
Received: from mailrelay3-3.pub.mailoutpod1-cph3.one.com (mailrelay3-3.pub.mailoutpod1-cph3.one.com [46.30.212.12])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id 1E0D6F609E8
	for <262@bugs.devuan.org>; Mon, 11 Mar 2019 11:05:31 +0100 (CET)
Authentication-Results: vm6.ganeti.dyne.org;
	dkim=pass (1024-bit key; unprotected) header.d=iaksess.no header.i=@iaksess.no header.b="MLMqj4E+";
	dkim-atps=neutral
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=iaksess.no; s=20140924;
	h=content-transfer-encoding:content-type:mime-version:references:in-reply-to:
	 message-id:subject:cc:to:from:date:from;
	bh=8VDmKrDBK32dIMnkxi5V0tSlEUHeAEPi0GZlnb42zZw=;
	b=MLMqj4E+XXIfwgDD91rZV3CG9FF9jwIjvbZXFeEZ9S1nxsTg1LTY/epDzJ/Ya9dm49OCWj4hFpHYx
	 zz3s9gYSX8VTCAgqewCdy3am2wNoh3CNhpQF1h9lU0dtQGTbTx23rxgMqNrlvgWgG6BTAeoKaW2wFH
	 JMP9MdBroZZOxE5A=
X-HalOne-Cookie: 6021c06dd3252eedad6962fad52b0eee8c56aac4
X-HalOne-ID: 33456c28-43e5-11e9-9a3a-d0431ea8bb03
Received: from sda3 (unknown [92.220.150.219])
	by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPA
	id 33456c28-43e5-11e9-9a3a-d0431ea8bb03;
	Mon, 11 Mar 2019 10:05:30 +0000 (UTC)
Date: Mon, 11 Mar 2019 11:05:28 +0100
From: Arnt Karlsen <arnt@iaksess.no>
To: 262@bugs.devuan.org
Cc: Arnt Karlsen <arnt@iaksess.no>, Adam Borowski <kilobyte@angband.pl>,
 913364@bugs.debian.org
Message-ID: <20190311110528.5999da20@sda3>
In-Reply-To: <20181122021559.60f6ac16@d44>
References: <20181110002821.03efcb2f@d44>
	<20181118002753.a4niphsc7bt4nee3@angband.pl>
	<20181110002821.03efcb2f@d44>
	<20181121164940.GA9763@drop.zugschlus.de>
	<20181110002821.03efcb2f@d44>
	<20181122021559.60f6ac16@d44>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=4.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,DKIM_VALID_EF,RAZOR2_CF_RANGE_51_100,RAZOR2_CHECK,
	RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.2
X-Spam-Level: ***
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org

On Thu, 22 Nov 2018 02:15:59 +0100, Arnt wrote in message 
<20181122021559.60f6ac16@d44>:
> 
> ..which part of:" # daily restart of atop at midnight
> 0 0 * * * root if [ -d "/run/systemd/system" ]; then systemctl \
> restart atop; else /usr/share/atop/atop.daily \& ; fi" "on a
> non-systemd box" did you miss?

[...]

> ..this bug is insisting on assuming systemctl etc systemd commands 
> and totally disregarding the fact some of us throw out junk "init"
> binaries and move on with ye aulde relics that just works, and fix 
> atop in https://bugs.devuan.org//cgi/bugreport.cgi?bug=262 when we 
> get such clear wont-fix hints in Message #15. 
> 
> ..if you Debian etc systemd guys _do_ wanna fix your #913364, put 
> back in the test for systemd and install atop.cronsystemd if you 
> find systemd on your boxes, and give the rest of us back our 
> beloved atop.cronsysv.  Etc.  Easily found in your well documented 
> $favorite_mirror/debian/pool/main/a/atop/atop_*tar* balls.


..instead you test for systemd every damned time cron runs atop...:
cat /etc/cron.d/atop:"
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root if [ -d "/run/systemd/system" ]; then systemctl
restart atop; else /usr/share/atop/atop.daily \& ; fi "

...when that test should happen once, everytime atop is upgraded to 
a new version, or reinstalled, or downgraded to a known good working
version etc, to _decide_which_version_ /etc/cron.d/atop to install,
either /etc/cron.d/atop.sysv _OR_ /etc/cron.d/atop.systemd.


..my _fixed_ /etc/cron.d/atop for non-systemd Devuan etc boxes...:"
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root /usr/share/atop/atop.daily \& "

...works nicely enough to warrant closing this bug.



..I would _guess_  an /etc/cron.d/atop like ...: "
PATH=/bin:/usr/bin:/sbin:/usr/sbin

# daily restart of atop at midnight
0 0 * * * root systemctl restart atop \& "

...would work for systemd boxes.


-- 
..med vennlig hilsen = with Kind Regards from Arnt Karlsen
...with a number of polar bear hunters in his ancestry...
  Scenarios always come in sets of three: 
  best case, worst case, and just in case.

Send a report that this bug log contains spam.

Devuan bug report logs - #262 [atop] ..atop installs systemd cron job on non-systemd Devuan box...

Devuan bug report logs - #262
[atop] ..atop installs systemd cron job on non-systemd Devuan box...