Devuan bug report logs - #506
libvirt-daemon-system should not depend on policykit-1

version graph

Package: libvirt-daemon-system; Maintainer for libvirt-daemon-system is Andreas Messer <andi@bastelmap.de>; Source for libvirt-daemon-system is src:libvirt.

Reported by: "Thierry B." <thierryb@zaclys.net>

Date: Wed, 12 Aug 2020 16:03:01 UTC

Severity: wishlist

Found in version 6.5.0-1

Fixed in version libvirt-daemon-system/6.5.0-1+devuan3

Done: Andreas Messer <andi@bastelmap.de>

Full log


Message #75 received at 506@bugs.devuan.org (full text, mbox, reply):

Received: (at 506) by bugs.devuan.org; 15 Aug 2020 10:10:06 +0000
Return-Path: <mark@hindley.org.uk>
Delivered-To: devuanbugs@dyne.org
Received: from tupac3.dyne.org [195.169.149.119]
	by doc.devuan.org with IMAP (fetchmail-6.4.0.beta4)
	for <debbugs@localhost> (single-drop); Sat, 15 Aug 2020 10:10:06 +0000 (UTC)
Received: from mx.hindley.org.uk (mohindley.plus.com [81.174.245.179])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by vm6.ganeti.dyne.org (Postfix) with ESMTPS id 16BA7F60CD9
	for <506@bugs.devuan.org>; Sat, 15 Aug 2020 12:04:32 +0200 (CEST)
Received: from apollo.hindleynet ([192.168.1.3] helo=hindley.org.uk)
	by mx.hindley.org.uk with smtp (Exim 4.84_2)
	(envelope-from <mark@hindley.org.uk>)
	id 1k6t38-0004pS-FR; Sat, 15 Aug 2020 11:04:30 +0100
Received: (nullmailer pid 22608 invoked by uid 1000);
	Sat, 15 Aug 2020 10:04:29 -0000
Date: Sat, 15 Aug 2020 11:04:29 +0100
From: Mark Hindley <mark@hindley.org.uk>
To: "Thierry B." <thierryb@zaclys.net>
Cc: 506@bugs.devuan.org, andi@bastelmap.de
Subject: Re: libvirt-daemon-system should not depend on policykit-1
Message-ID: <20200815100429.GE3011@hindley.org.uk>
References: <de895771-ac7e-6aad-8424-2181fbe7a1b8@zaclys.net>
 <20200813090541.GP3011@hindley.org.uk>
 <3ed4496b-2ccb-5bee-d19a-bff72c1ca646@zaclys.net>
 <20200813131740.GS3011@hindley.org.uk>
 <a09547c4-ee89-f6db-3635-3fbbbb59ec0f@zaclys.net>
 <20200814135138.GA3011@hindley.org.uk>
 <fc3d4aaa-3d22-7e37-15b9-11e050451615@zaclys.net>
 <20200814210242.GC3011@hindley.org.uk>
 <c6b3a7ca-b407-c675-8b78-b412d9f51774@zaclys.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c6b3a7ca-b407-c675-8b78-b412d9f51774@zaclys.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=disabled
	version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tupac3.dyne.org
Thierry,

On Fri, Aug 14, 2020 at 11:08:34PM +0200, Thierry B. wrote:
> > I have noticed a couple of things that need to be addressed. I will do a proper
> > review tomorrow.
> > 
> > Thanks for your work so far.
> > 
> > Mark
> > 
> All this for changing 10 characters in control file!

Well more for being persistent and being prepared to learn the process :)

You may have seen that Andreas Messer also offered to help.  So you may want to
do this jointly? The d/control Maintainer field can only take a single email address, but
other addresses can be added to Uploaders.

I have had a quick look and these issues struck me as needing attention:

d/control:

 - Set yourself as maintainer.
 - Remove uploaders (or replace with Andreas Messer?).
 - Remove the libvirt-daemon-system-systemd package. It will always be broken in Devuan.
 - Update the libvirt-daemon-system-sysv description to remove the systemd as default/preferred reference.

d/changelog:

 - Add '(Closes: #506)' so the bug will be automatically closed when the package
   enters the archive.
 - Maybe add a 'Fork for Devuan' entry to cover other changes?

Other than that, it builds and is reasonably lintian clean. It will be worth
checking with lintian again after you have made these new changes.

Let me know how you get on. #devuan-dev on irc.freenode.net is a good place to
get quick help.

Thanks

Mark (LeePen)

Send a report that this bug log contains spam.


Devuan BTS -- Powered by Debian bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.

Devuan Bugs Owner <owner@bugs.devuan.org>.
Last modified: Fri Apr 26 12:26:58 2024;