Devuan bug report logs - #761
slim: label position in slimlock vs. slim (fix included)

Package: slim; Maintainer for slim is Devuan Dev Team <devuan-dev@lists.dyne.org>; Source for slim is src:slim.

Reported by: tom314@posteo.net

Date: Thu, 8 Jun 2023 23:14:01 UTC

Severity: normal

Found in version slim/1.4.0-0devuan2

Fixed in version 1.4.0-0devuan3

Done: dak@devuan.org

Full log

Message #5 received at submit@bugs.devuan.org (full text, mbox, reply):

Received: (at submit) by bugs.devuan.org; 8 Jun 2023 23:12:02 +0000
Return-Path: <tom314@posteo.net>
Delivered-To: bugs@devuan.org
Received: from email.devuan.org [2a01:4f8:140:32a1::58c6:6473]
	by doc.devuan.org with IMAP (fetchmail-6.4.16)
	for <debbugs@localhost> (single-drop); Thu, 08 Jun 2023 23:12:02 +0000 (UTC)
Received: from email.devuan.org
	by email.devuan.org with LMTP
	id 0BFPNxJggmTUMAAAmSBk0A
	(envelope-from <tom314@posteo.net>)
	for <bugs@devuan.org>; Thu, 08 Jun 2023 23:11:14 +0000
Received: by email.devuan.org (Postfix, from userid 109)
	id D6093739; Thu,  8 Jun 2023 23:11:14 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on email.devuan.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,RCVD_IN_DNSWL_MED,SPF_PASS autolearn=ham
	autolearn_force=no version=3.4.6
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.67.36.66; helo=mout02.posteo.de; envelope-from=tom314@posteo.net; receiver=<UNKNOWN> 
Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66])
	by email.devuan.org (Postfix) with ESMTPS id 1F37C27
	for <submit@bugs.devuan.org>; Thu,  8 Jun 2023 23:11:08 +0000 (UTC)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout02.posteo.de (Postfix) with ESMTPS id 52692240101
	for <submit@bugs.devuan.org>; Fri,  9 Jun 2023 01:11:07 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
	t=1686265867; bh=/nrQDCYBIFubR3JCTIOq0VACKrJbJj3vP/ltO3lq4O8=;
	h=MIME-Version:Date:From:To:Subject:Message-ID:From;
	b=KLntpeR+9JU0O205DTTKUSqMviBk86YZpxNB7NrC/itTE8vlHxMzMgC2LLQeRpKrF
	 D++cMe6vmtQrTCdLhnUOdeIk0Ywd1uhvu2GKqLe6Kq4L16xDseHdKKeiXuk+fjIqdX
	 hq0RsSVoyZ/ENRcoHVSPe/b25Ms+0VtD0l0jMt5aYpDNlmcqzj4IFHeibHNSeyIGle
	 GCy8RXSw5ivvpEQUvDMSXrW8hhs5fLKTfMh/86Oa+PhwCJANkJzyspMtozwSvO9KNi
	 nq3TQEoOiipNzwf5ORkiLoPDQTcnWg2YBfzqiR/eupfObIdkllcD88bM780gD9hXIj
	 5ySJhEulYug3g==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4Qcg1k6yXfz6txQ
	for <submit@bugs.devuan.org>; Fri,  9 Jun 2023 01:11:06 +0200 (CEST)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_c30bfa7182ea6542671d5f7a11637716"
Date: Thu, 08 Jun 2023 23:11:06 +0000
From: tom314@posteo.net
To: submit@bugs.devuan.org
Subject: slim: label position in slimlock vs. slim (fix included)
Message-ID: <e224af31c89758856aab906def0687c7@posteo.net>

[Message part 1 (text/plain, inline)]

package: slim
version: 1.4.0-0devuan2

slimlock shows two text-labels (welcome_ and password_). Placement is 
relative background, but should be relativepanel-image, like slim.
This is invisible when using a current Devuan theme(s): The panel-image 
is placed at 0,0, which equalises the origins in slim and slimlock.
Fix: small patch included, mostly comments in the source as patch-notes. 
Maintainers may use it as they see fit.
Patch file: 
"slim__slimlock_label_positions__welcome_and_password__bugfix.patch"

System: daedalus
Kernel: 6.3.6-1-liquorix-amd64
((chimaera's 1.3.6: Patch applies with comments rejected. Seems to work 
for welcome_ and username_ (not hidden), but not for password_)).


Part II:
Dear maintainer,
beside the bug fix, there is a small piece of code to handle in-line 
comments in config files, which is attached too.

Proposed feature: Handle in-line comments in config files (slim.theme).
Reason: Before realising the error, I used in-line comments during 
theme'ing.
Patch file: "slim__in-line_comments_in_config_files__addon.patch"
This may or may not be considered useful.


Both are tested, but I'm not really a software developer.
Feel free to contact me for any issues.

Thanks for devuan, slim and all the effort!
Regards,
Thomas

[slim__slimlock_label_positions__welcome_and_password__bugfix.patch (text/x-patch, attachment)]

[slim__in-line_comments_in_config_files__addon.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.

Devuan bug report logs - #761 slim: label position in slimlock vs. slim (fix included)

Devuan bug report logs - #761
slim: label position in slimlock vs. slim (fix included)